From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>,
Joern Engel <joern@lazybastard.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: kernel@axis.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] mtd: phram: Allow cached mappings
Date: Thu, 12 May 2022 17:27:01 +0200 [thread overview]
Message-ID: <20220512152701.244667-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220510151822.1809278-1-vincent.whitchurch@axis.com>
On Tue, 2022-05-10 at 15:18:22 UTC, Vincent Whitchurch wrote:
> Currently phram always uses ioremap(), but this is unnecessary when
> normal memory is used. If the reserved-memory node does not specify the
> no-map property, indicating it should be mapped as system RAM and
> ioremap() cannot be used on it, use a cached mapping using
> memremap(MEMREMAP_WB) instead.
>
> On one of my systems this improves read performance by ~70%.
>
> (Note that this driver has always used normal memcpy/memset functions on
> memory obtained from ioremap(), which sparse doesn't like. There is no
> memremap() variant which maps exactly to ioremap() on all architectures,
> so that behaviour of the driver is not changed to avoid affecting
> existing users, but the sparse warnings are suppressed in the moved code
> with __force.)
>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
prev parent reply other threads:[~2022-05-12 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 15:18 Vincent Whitchurch
2022-05-12 15:27 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512152701.244667-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=joern@lazybastard.org \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®