From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Haowen Bai <baihaowen@meizu.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: VR41xx: Drop redundant spinlock initialization
Date: Thu, 12 May 2022 18:08:53 +0200 [thread overview]
Message-ID: <20220512160853.GB14475@alpha.franken.de> (raw)
In-Reply-To: <1652176527-4507-1-git-send-email-baihaowen@meizu.com>
On Tue, May 10, 2022 at 05:55:27PM +0800, Haowen Bai wrote:
> slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
> so we don't need to spin_lock_init again, drop it.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> arch/mips/vr41xx/common/cmu.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/vr41xx/common/cmu.c b/arch/mips/vr41xx/common/cmu.c
> index b59ee5479313..e4cbe116b26d 100644
> --- a/arch/mips/vr41xx/common/cmu.c
> +++ b/arch/mips/vr41xx/common/cmu.c
> @@ -236,8 +236,6 @@ static int __init vr41xx_cmu_init(void)
> if (current_cpu_type() == CPU_VR4133)
> cmuclkmsk2 = cmu_read(CMUCLKMSK2);
>
> - spin_lock_init(&cmu_lock);
> -
> return 0;
> }
>
> --
> 2.7.4
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2022-05-12 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 9:55 Haowen Bai
2022-05-12 16:08 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512160853.GB14475@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=baihaowen@meizu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®