From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52403C433EF for ; Fri, 13 May 2022 04:05:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376961AbiEMEFx (ORCPT ); Fri, 13 May 2022 00:05:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376946AbiEMEFi (ORCPT ); Fri, 13 May 2022 00:05:38 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5752229B025 for ; Thu, 12 May 2022 21:05:37 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-2f9299dfb81so62175287b3.6 for ; Thu, 12 May 2022 21:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=MAjYUcMF8cvSpD3IrXmmGZ0bseIJMHTYZTi0/EOkzbY=; b=DNyinQnf/GUhB5FLBjS/bka3DAXeZ27SjcHtaiafd1Qa3TdKFMJt+APa+eIJ94K/9c M2Kmp0d2XIqVr7OgZAk1uQ7LRJ8yfxqj0a/801WoLD14owWZO85tRgRSn9Ce+1KF9FN7 S0jsg8y8RBplqLugtk2HKhLIpuHn0vlX53V0xyh0S4u81HTT6TFRwsKbjYZlbnYxNT7B SwvMHY4CmmZ2hJuhE8VVNH3UTeaHaOBzCIVRCdZMO6Yv9LRvV1dkV74szp0o9qf5cEkC PqRsbQjbtbMjq0xx5n0nYy0jOm7irRg2CsfHLBcwEhaxoKqhiViCwJb0EFIWdIOdAGrs fO3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=MAjYUcMF8cvSpD3IrXmmGZ0bseIJMHTYZTi0/EOkzbY=; b=xymk+Mf3k/066oTKrJjlVEpTWIvEV+kUjyd84nobaz0CQ3KvVakZ7aKHAgvtCf8eVx +4w0eLoeVFloJLlFXqiaXx96DQH3DiXzXbzUXC+vuyz6vhYYfx7CRzkc5IP4e4CiznQ0 /L2WWC/d3tKM/0Hf0RIIOE7Mj8k/QPu8daXlNfHg3g/BlCJ4Ag7/xoEH1AjSNP9AYeY8 EQ9tpnvRPZ6SBLSIMNE+mRZ2/67h3A7BCOLtBVFr1N74jaimmLb8H+dUfVHRa3p/5lxv sWq/AuMexbpPuMdyLxy4iSpTnY4hKh4Q3lY9n1N99uOeAnRZywsKaoTpPxviejGiOaB/ 8f5Q== X-Gm-Message-State: AOAM531tspd+aHIgg5ziWIF78P2aZ3SnYTKyRDI+0rPz1I4XxlUe6JMN CE7P3zIq7f6JkwEqjWPXcFwImtv6DwfF X-Google-Smtp-Source: ABdhPJx7EU8oJlo555wKZBuqFQ51tkxeRs8J6Bf5Kloe7Bej4z8wYTVAiSh8jJYEqJ11bCd2O1L2U7vU3hkT X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:9b61:c91f:ca29:ae54]) (user=irogers job=sendgmr) by 2002:a25:dfc3:0:b0:64b:3228:73fc with SMTP id w186-20020a25dfc3000000b0064b322873fcmr2977029ybg.441.1652414736234; Thu, 12 May 2022 21:05:36 -0700 (PDT) Date: Thu, 12 May 2022 21:05:17 -0700 In-Reply-To: <20220513040519.1499333-1-irogers@google.com> Message-Id: <20220513040519.1499333-6-irogers@google.com> Mime-Version: 1.0 References: <20220513040519.1499333-1-irogers@google.com> X-Mailer: git-send-email 2.36.0.550.gb090851708-goog Subject: [PATCH 5/7] perf test: Parse events tidy terms_test From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Riccardo Mancini , Sohaib Mohamed , Carsten Haitzler , Marco Elver , John Garry , Michael Petlan , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stephane Eranian , Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove an unused variables. Make structs const. Fix checkpatch issue wrt unsigned not being with an int. Signed-off-by: Ian Rogers --- tools/perf/tests/parse-events.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c index e71efadb24f5..7e802666d2d5 100644 --- a/tools/perf/tests/parse-events.c +++ b/tools/perf/tests/parse-events.c @@ -1980,11 +1980,10 @@ static struct evlist_test test__events_pmu[] = { struct terms_test { const char *str; - __u32 type; int (*check)(struct list_head *terms); }; -static struct terms_test test__terms[] = { +static const struct terms_test test__terms[] = { [0] = { .str = "config=10,config1,config2=3,umask=1,read,r0xead", .check = test__checkterms_simple, @@ -2112,7 +2111,7 @@ static int test_events(struct evlist_test *events, unsigned cnt) return ret2; } -static int test_term(struct terms_test *t) +static int test_term(const struct terms_test *t) { struct list_head terms; int ret; @@ -2139,13 +2138,12 @@ static int test_term(struct terms_test *t) return ret; } -static int test_terms(struct terms_test *terms, unsigned cnt) +static int test_terms(const struct terms_test *terms, int cnt) { int ret = 0; - unsigned i; - for (i = 0; i < cnt; i++) { - struct terms_test *t = &terms[i]; + for (int i = 0; i < cnt; i++) { + const struct terms_test *t = &terms[i]; pr_debug("running test %d '%s'\n", i, t->str); ret = test_term(t); -- 2.36.0.550.gb090851708-goog