From: Peter Zijlstra <peterz@infradead.org>
To: Giovanni Gherdovich <ggherdovich@suse.cz>
Cc: Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: Fix return value in frequency invariance setup for XEON_PHI_KNL/KNM
Date: Sat, 21 May 2022 12:02:24 +0200 [thread overview]
Message-ID: <20220521100224.GB2578@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220520161022.5972-1-ggherdovich@suse.cz>
On Fri, May 20, 2022 at 06:10:21PM +0200, Giovanni Gherdovich wrote:
> knl_set_max_freq_ratio() should return true on success and false
> otherwise. If the last line of the function body is reached, it means no
> appropriate value for turbo_freq was found: the setup is unsuccessful and
> it should return false.
>
> Fixes: 8bea0dfb4a82 ("x86, sched: Add support for frequency invariance on XEON_PHI_KNL/KNM")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Giovanni Gherdovich <ggherdovich@suse.cz>
> ---
> arch/x86/kernel/smpboot.c | 2 +-
You seems to have missed all that code moved in tip. This no longer
applies.
next prev parent reply other threads:[~2022-05-21 10:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 16:10 Giovanni Gherdovich
2022-05-20 16:10 ` [PATCH 2/2] x86: fix platform info detection in frequency invariance Giovanni Gherdovich
2022-05-20 16:44 ` Dave Hansen
2022-05-23 9:56 ` Giovanni Gherdovich
2022-05-21 10:02 ` Peter Zijlstra [this message]
2022-05-23 9:57 ` [PATCH 1/2] x86: Fix return value in frequency invariance setup for XEON_PHI_KNL/KNM Giovanni Gherdovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220521100224.GB2578@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=dan.carpenter@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=ggherdovich@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome