Re: [PATCH v2 9/11] perf c2c: Sort on peer snooping for load operations

[Leo Yan <leo.yan@linaro.org>]

On Thu, May 19, 2022 at 05:06:18PM +0800, Adam Li wrote:
> Hi Leo,
> 
> Thanks for the update.
> On 5/18/2022 2:12 PM, Leo Yan wrote:
>  
> > Please note, in the total statistics, all remote accesses will be
> > accounted into metric "rmt_hit", so "rmt_hit" includes the access for
> > remote DRAM or any upwards cache levels due we cannot distinguish
> > them.
> >
> 
> Agree that "Load Remote HIT" makes more sense than "Load Remote DRAM".
>  
> > From my experiment, with this updating the output result is promised
> > for the peer accesses and it's easier for inspecting false sharing.
> > 
> > As you might see I have prepared a git repo:
> > https://git.linaro.org/people/leo.yan/linux-spe.git/ branch:
> > perf_c2c_arm_spe_peer_v3, which contains the updated patches for both
> > memory flag setting and perf c2c related patches.
> > 
> > Could you confirm if the updated code works for you or not?
> > 
> 
> I tested v3 patch (perf_c2c_arm_spe_peer_v3 branch) on 2P Altra system.
> 
> Compared with v2, "Snoop Peer" can better indicate cache false-sharing,
> for the 'false_sharing.exe' test case.

Thanks a lot for the testing and confirmation, Adam.

I will update the patches based on the comments from Joe and James,
after get ready will send out the patch set and loop you.

Thanks,
Leo