From: ChenXiaoSong <chenxiaosong2@huawei.com>
To: <miklos@szeredi.hu>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<chenxiaosong2@huawei.com>, <liuyongqiang13@huawei.com>,
<yi.zhang@huawei.com>, <zhangxiaoxu5@huawei.com>
Subject: [PATCH -next,v2] fuse: return the more nuanced writeback error on close()
Date: Mon, 23 May 2022 09:48:38 +0800 [thread overview]
Message-ID: <20220523014838.1647498-1-chenxiaosong2@huawei.com> (raw)
As filemap_check_errors() only report -EIO or -ENOSPC, we return more nuanced
writeback error -(file->f_mapping->wb_err & MAX_ERRNO).
filemap_write_and_wait
filemap_write_and_wait_range
filemap_check_errors
-ENOSPC or -EIO
filemap_check_wb_err
errseq_check
return -(file->f_mapping->wb_err & MAX_ERRNO)
Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
---
fs/fuse/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index f18d14d5fea1..9917bc2795e6 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -488,10 +488,10 @@ static int fuse_flush(struct file *file, fl_owner_t id)
inode_unlock(inode);
err = filemap_check_errors(file->f_mapping);
+ /* return more nuanced writeback errors */
if (err)
- return err;
+ return filemap_check_wb_err(file->f_mapping, 0);
- err = 0;
if (fm->fc->no_flush)
goto inval_attr_out;
--
v2: remove redundant code: err = 0
2.31.1
next reply other threads:[~2022-05-23 1:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 1:48 ChenXiaoSong [this message]
2022-05-30 12:13 ` Miklos Szeredi
2022-05-30 14:02 ` Jeff Layton
2022-05-30 14:38 ` Miklos Szeredi
2022-05-30 22:33 ` NeilBrown
2022-05-31 15:31 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523014838.1647498-1-chenxiaosong2@huawei.com \
--to=chenxiaosong2@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyongqiang13@huawei.com \
--cc=miklos@szeredi.hu \
--cc=yi.zhang@huawei.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®