From: Mario Limonciello <mario.limonciello@amd.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>, <hdegoede@redhat.com>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH 2/3] ata: ahci: Rename module parameter for lpm policy
Date: Tue, 24 May 2022 12:05:07 -0500 [thread overview]
Message-ID: <20220524170508.563-3-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220524170508.563-1-mario.limonciello@amd.com>
The LPM policy is applied to more chipsets than just mobile designs.
Update the module parameter to drop the word "mobile" to make this
clearer to users.
Also, document this renamed parameter in the admin-guide for users
as it was missing previously.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
Documentation/admin-guide/kernel-parameters.txt | 11 +++++++++++
drivers/ata/ahci.c | 10 +++++-----
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 9336d98fc670..9e6bd212004d 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -268,6 +268,17 @@
try_unsupported: try to drive unsupported chipsets
(may crash computer or cause data corruption)
+ ahci.lpm_policy= [AHCI]
+ The Default SATA Link Power Management (LPM) policy to use
+ for chipsets / "South Bridges" supporting low-power modes.
+
+ The value set has the following meanings:
+ 0 => Keep firmware settings
+ 1 => Maximum performance
+ 2 => Medium power
+ 3 => Medium power with Device Initiated PM enabled
+ 4 => Minimum power
+
ALSA [HW,ALSA]
See Documentation/sound/alsa-configuration.rst
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index c39cdf6a44f1..1e2febea2f28 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -640,9 +640,9 @@ static int marvell_enable = 1;
module_param(marvell_enable, int, 0644);
MODULE_PARM_DESC(marvell_enable, "Marvell SATA via AHCI (1 = enabled)");
-static int mobile_lpm_policy = -1;
-module_param(mobile_lpm_policy, int, 0644);
-MODULE_PARM_DESC(mobile_lpm_policy, "Default LPM policy for mobile chipsets");
+static int lpm_policy = -1;
+module_param(lpm_policy, int, 0644);
+MODULE_PARM_DESC(lpm_policy, "Default LPM policy");
static void ahci_pci_save_initial_config(struct pci_dev *pdev,
struct ahci_host_priv *hpriv)
@@ -1591,8 +1591,8 @@ static void ahci_update_initial_lpm_policy(struct ata_port *ap,
int policy = CONFIG_SATA_MOBILE_LPM_POLICY;
/* user modified policy via module param */
- if (mobile_lpm_policy != -1) {
- policy = mobile_lpm_policy;
+ if (lpm_policy != -1) {
+ policy = lpm_policy;
goto update_policy;
}
--
2.34.1
next prev parent reply other threads:[~2022-05-24 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 17:05 [PATCH v3 0/3] Drop mobile board support Mario Limonciello
2022-05-24 17:05 ` [PATCH 1/3] ata: ahci: Drop low power policy board type Mario Limonciello
2022-05-24 17:05 ` Mario Limonciello [this message]
2022-05-25 9:03 ` [PATCH 2/3] ata: ahci: Rename module parameter for lpm policy Christoph Hellwig
2022-05-25 11:11 ` Damien Le Moal
2022-05-24 17:05 ` [PATCH 3/3] ahci: Document the loss of hotplug by new LPM policy Mario Limonciello
2022-05-25 9:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524170508.563-3-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®