From: "Paul E. McKenney" <paulmck@kernel.org>
To: Zqiang <qiang1.zhang@intel.com>
Cc: frederic@kernel.org, rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Add no-idle tasks check which in dyntick-idle state
Date: Tue, 24 May 2022 10:28:55 -0700 [thread overview]
Message-ID: <20220524172855.GP1790663@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <20220524003454.1887414-1-qiang1.zhang@intel.com>
On Tue, May 24, 2022 at 08:34:52AM +0800, Zqiang wrote:
> These commit stop scanning no-idle tasks which in dyntick-idle state and
> remove idle-tasks check from warnings.
This patch might well be correct, but there are supposed to be upcoming
changes in the idle loop that would make it possible for RCU Tasks to
take idle tasks into account:
https://lore.kernel.org/all/20220515203653.4039075-1-jolsa@kernel.org/
There are currently issues in amd_e400_idle() and mwait_idle() preventing
this, and there might well also be similar issues in non-x86 idle loops:
https://lore.kernel.org/all/20220519135439.GX1790663@paulmck-ThinkPad-P17-Gen-1/
So I must hold off on this patch series for the time being. Nevertheless,
thank you very much for your effort and interest in RCU.
Thanx, Paul
> v1->v2:
> fix build error when CONFIG_TASKS_RCU=n
> v2->v3:
> remove idle-tasks check from task_is_on_dyntick_idle()
>
> Zqiang (2):
> rcu-tasks: Stop RCU Tasks scanning no-idle tasks which record on
> dyntick-idle entry
> rcu-tasks: Remove is_idle_task() from warnings in check_holdout_task()
>
> kernel/rcu/tasks.h | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-05-24 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 0:34 Zqiang
2022-05-24 0:34 ` [PATCH v3 1/2] rcu-tasks: Stop RCU Tasks scanning no-idle tasks which record on dyntick-idle entry Zqiang
2022-05-24 0:34 ` [PATCH v3 2/2] rcu-tasks: Remove is_idle_task() from warnings in check_holdout_task() Zqiang
2022-05-24 17:28 ` Paul E. McKenney [this message]
2022-05-24 22:28 ` [PATCH v3 0/2] Add no-idle tasks check which in dyntick-idle state Zhang, Qiang1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524172855.GP1790663@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiang1.zhang@intel.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®