From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B03EC433F5 for ; Wed, 25 May 2022 14:07:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236678AbiEYOHZ convert rfc822-to-8bit (ORCPT ); Wed, 25 May 2022 10:07:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245661AbiEYOF4 (ORCPT ); Wed, 25 May 2022 10:05:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C79609CCAC for ; Wed, 25 May 2022 07:05:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 539826190D for ; Wed, 25 May 2022 14:05:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F9D1C385B8; Wed, 25 May 2022 14:05:28 +0000 (UTC) Date: Wed, 25 May 2022 10:05:26 -0400 From: Steven Rostedt To: Jakub =?UTF-8?B?TWF0xJtuYQ==?= Cc: linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, vbabka@suse.cz, mhocko@kernel.org, mgorman@techsingularity.net, willy@infradead.org, liam.howlett@oracle.com, hughd@google.com, kirill@shutemov.name, riel@surriel.com, peterz@infradead.org, david@redhat.com Subject: Re: [RFC PATCH v3 6/6] [PATCH 6/6] mm: add tracing for VMA merges Message-ID: <20220525100526.2a7a0eb7@gandalf.local.home> In-Reply-To: <20220516125405.1675-7-matenajakub@gmail.com> References: <20220516125405.1675-1-matenajakub@gmail.com> <20220516125405.1675-7-matenajakub@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 May 2022 14:54:05 +0200 Jakub Matěna wrote: > + TP_fast_assign( > + __entry->merged = merged == 0; > + __entry->predecessor_different_av = merge_prev; > + __entry->successor_different_av = merge_next; > + __entry->predecessor_with_successor_different_av = merge_both; > + __entry->same_count = (merge_prev == AV_MERGE_SAME) + > + (merge_next == AV_MERGE_SAME) + > + (merge_both == AV_MERGE_SAME); > + __entry->diff_count = (merge_prev == AV_MERGE_DIFFERENT) + > + (merge_next == AV_MERGE_DIFFERENT) + > + (merge_both == AV_MERGE_DIFFERENT); > + __entry->failed_count = (merge_prev == AV_MERGE_FAILED) + > + (merge_next == AV_MERGE_FAILED) + > + (merge_both == AV_MERGE_FAILED); The above looks like it can be moved into the TP_printk(), as you have the merge_prev, next and both saved already. Why waste more ring buffer space and execution time for information that can be derived at the time of reading the trace event? -- Steve > + ), > + > + TP_printk("merged=%d predecessor=%s successor=%s predecessor_with_successor=%s same_count=%d diff_count=%d failed_count=%d", > + __entry->merged, > + __print_symbolic(__entry->predecessor_different_av, AV_MERGE_TYPES), > + __print_symbolic(__entry->successor_different_av, AV_MERGE_TYPES), > + __print_symbolic(__entry->predecessor_with_successor_different_av, AV_MERGE_TYPES), > + __entry->same_count, __entry->diff_count, __entry->failed_count) > + > +); > +