From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Chenyi Qiang <chenyi.qiang@intel.com>,
Lei Wang <lei4.wang@intel.com>
Subject: [PATCH 0/2] KVM: VMX: Sanitize VM-Entry/VM-Exit pairs during setup
Date: Wed, 25 May 2022 21:04:45 +0000 [thread overview]
Message-ID: <20220525210447.2758436-1-seanjc@google.com> (raw)
Sanitize the VM-Entry/VM-Exit load+load and load+clear pairs when kvm_intel
is loaded instead of checking both controls at runtime. Not sanitizing
means KVM ends up setting non-dynamic bits in the VMCS.
Add an opt-in knob to force kvm_intel to bail if an inconsistent pair is
detected instead of using a degraded and/or potentially broken setup.
Arguably patch 01 is stable material, but my mental coin flip came up
negative and I didn't Cc: stable.
And for patch 02, I'd definitely be favor of making it opt-out instead of
opt-in, but there's a non-zero chance that someone out there is running
KVM in a misconfigured VM...
Sean Christopherson (2):
KVM: VMX: Sanitize VM-Entry/VM-Exit control pairs at kvm_intel load
time
KVM: VMX: Add knob to allow rejecting kvm_intel on inconsistent VMCS
config
arch/x86/kvm/vmx/capabilities.h | 13 +++-----
arch/x86/kvm/vmx/vmx.c | 55 +++++++++++++++++++++++++++++++--
2 files changed, 56 insertions(+), 12 deletions(-)
base-commit: 90bde5bea810d766e7046bf5884f2ccf76dd78e9
--
2.36.1.124.g0e6072fb45-goog
next reply other threads:[~2022-05-25 21:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 21:04 Sean Christopherson [this message]
2022-05-25 21:04 ` [PATCH 1/2] KVM: VMX: Sanitize VM-Entry/VM-Exit control pairs at kvm_intel load time Sean Christopherson
2022-05-25 23:27 ` Yuan Yao
2022-05-26 0:42 ` Sean Christopherson
2022-05-26 1:04 ` Yuan Yao
2022-05-26 10:39 ` Paolo Bonzini
2022-05-26 21:35 ` Sean Christopherson
2022-05-27 9:44 ` Paolo Bonzini
2022-05-25 21:04 ` [PATCH 2/2] KVM: VMX: Add knob to allow rejecting kvm_intel on inconsistent VMCS config Sean Christopherson
2022-05-25 21:17 ` Jim Mattson
2022-05-26 0:45 ` Sean Christopherson
2022-05-26 1:00 ` Jim Mattson
2022-05-26 10:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220525210447.2758436-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=chenyi.qiang@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=lei4.wang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®