mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: sunliming <sunliming@kylinos.cn>,
	mingo@kernel.org, linux-tip-commits@vger.kernel.org,
	dave.hansen@linux.intel.com, x86@kernel.org,
	linux-kernel@vger.kernel.org, kelulanainsley@gmail.com
Subject: Re: [PATCH V2] x86/idt: traceponit.c: fix comment for irq vector tracepoints
Date: Thu, 26 May 2022 14:38:44 -0400	[thread overview]
Message-ID: <20220526143844.2d5c8741@gandalf.local.home> (raw)
In-Reply-To: <8f3be3c2-dcd0-1646-b5bd-0a6597e7ca2e@intel.com>

On Thu, 26 May 2022 09:24:31 -0700
Dave Hansen <dave.hansen@intel.com> wrote:

> On 5/26/22 04:08, sunliming wrote:
> > 
> > diff --git a/arch/x86/kernel/tracepoint.c b/arch/x86/kernel/tracepoint.c
> > index fcfc077afe2d..065191022035 100644
> > --- a/arch/x86/kernel/tracepoint.c
> > +++ b/arch/x86/kernel/tracepoint.c
> > @@ -1,9 +1,6 @@
> >  // SPDX-License-Identifier: GPL-2.0
> >  /*
> > - * Code for supporting irq vector tracepoints.
> > - *
> >   * Copyright (C) 2013 Seiji Aguchi <seiji.aguchi@hds.com>
> > - *
> >   */
> >  #include <linux/jump_label.h>
> >  #include <linux/atomic.h>  
> 
> While I'm also generally careful about removing others' copyrights, Mr.
> Aguchi only touched this file once and all of the code from that one
> touch appears to be gone to me.  Shouldn't we just zap the whole comment?

Perhaps, but that's a different change than this is addressing. This is
only addressing fixing the comments about the removal of the code.

But looking at the history of this file. Seiji created it, but the only
code that remains in the file was mostly added by Thomas. The only lines
that Seiji has now is the whitespace and the brackets.

I would still have the removal of the copyright as a separate patch.

-- Steve

      reply	other threads:[~2022-05-26 18:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 11:08 sunliming
2022-05-26 16:24 ` Dave Hansen
2022-05-26 18:38   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220526143844.2d5c8741@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=kelulanainsley@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=sunliming@kylinos.cn \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®