From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 581DBC433EF for ; Thu, 26 May 2022 22:45:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349304AbiEZWp0 (ORCPT ); Thu, 26 May 2022 18:45:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349065AbiEZWpW (ORCPT ); Thu, 26 May 2022 18:45:22 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5FBDEAD0D for ; Thu, 26 May 2022 15:45:20 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-2fb7cb07885so24522567b3.23 for ; Thu, 26 May 2022 15:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=jIodQqUTF1PbRDw3tEZrxjW1DLcLvwsf51++gy81Ao4=; b=bNc21YHtZhA4cFqL30hsg2EWcyiLMHiFXOvUEvo5TRQdcrDz2miWUbOMV6eJ+u2jVu EVBUVtyxyc2BRrBLopwThdnen4+59PTwuFeE3zxbXLjfRAf8q9UVtXqv74rVGgB3yd+l 1ieknSdYsychMF6Asnzyy+oB7RDHRyopKdhL2MR+JvLaHsw/Dyzd78vXISwJFt27b9OO XH2NGFzf64P8QmnroL2jHkFSvr4oSFvjFkAXKYJKACC++9SnxQTefNU4wUn3dA+hHXru ifDqPoASXGOOx7cKkG6n9VvxrekXo6axJ2ezthjQTILlBJZw3RA6RvjHTt0FqqrNR654 L/EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=jIodQqUTF1PbRDw3tEZrxjW1DLcLvwsf51++gy81Ao4=; b=bjAxSroM/PeDW3St3zFwa/hEsRl3+FpB3S/Q+c13RwY8x/MoazpC2FOeRbnyY//E5n LH6rvubVHdmHtONXUkyvxvQxun+NoNx2vnu8dnr3phkpLgiDSBDzIUw04KGETPtF3Cxi rVHD0XbURrvHGLdfQEnKW9pK4Lg78SfVMDoz9BVJqYvjBy6sYuoRhf4d01S3bvml5h8t WIv/ouDk2bP/Zocp4NP1jxCx72rzD49ok/VtCYImnd9xN5fmYc0+tYYUvpIZEJyletJY zSR9lZUI/mLWHx+cGcm6vsB+XgGjnpklFvOoqnhT6zUWlYebfWZIIX6Ruz5gICQGIFxe 9G1w== X-Gm-Message-State: AOAM533xD+ZZqPa+MPNpXuSlEjG3Y/HGLLwDd9ImzVHwtzYFAxXJrL+Z XQ3T/fK28qAtlUO9PhXO+oFIy1MfzPbb X-Google-Smtp-Source: ABdhPJzKyc8d19p/UH4LZ48Y6J8deQk/1R55EgGQCFn24MD4VK/AYiqWqd3iOZGVgYjSkftP4Pw9OLSBaMvF X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:4b39:e167:e698:7d4]) (user=irogers job=sendgmr) by 2002:a25:3204:0:b0:65b:2c0d:3983 with SMTP id y4-20020a253204000000b0065b2c0d3983mr29828yby.89.1653605119079; Thu, 26 May 2022 15:45:19 -0700 (PDT) Date: Thu, 26 May 2022 15:45:13 -0700 Message-Id: <20220526224515.4088240-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.36.1.124.g0e6072fb45-goog Subject: [PATCH v5 0/2] JSON output for perf stat From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kan Liang , Zhengjun Xing , Sandipan Das , Claire Jensen , Alyssa Ross , Like Xu , James Clark , Florian Fischer , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Claire Jensen Cc: Stephane Eranian , Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Parsing the CSV or text output of perf stat can be problematic when new output is added (columns in CSV format). JSON names values and simplifies the job of parsing. Add a JSON output option to perf-stat then add unit test that parses and validates the output. This is a resend of two v2 patches: https://lore.kernel.org/lkml/20210813220754.2104922-1-cjense@google.com/ https://lore.kernel.org/lkml/20210813220936.2105426-1-cjense@google.com/ with a few formatting changes and improvements to the linter. v5. Drops the merged CSV check, fixes a json test issue found by Arnaldo and a typo. v4. Does some minor fixes to the json linter. v3. There is some tidy up of CSV code including a potential memory over run in the os.nfields set up caught by sanitizers. To facilitate this an AGGR_MAX value is added. v3 also adds the CSV testing. v2. Fixes the system wide no aggregation test to not run if the paranoia is wrong. It also makes the counter-value check handle the "" and "" cases. Claire Jensen (2): perf stat: Add JSON output option perf test: Json format checking tools/perf/Documentation/perf-stat.txt | 21 + tools/perf/builtin-stat.c | 6 + .../tests/shell/lib/perf_json_output_lint.py | 95 +++++ tools/perf/tests/shell/stat+json_output.sh | 147 +++++++ tools/perf/util/stat-display.c | 384 +++++++++++++----- tools/perf/util/stat.c | 1 + tools/perf/util/stat.h | 2 + 7 files changed, 550 insertions(+), 106 deletions(-) create mode 100644 tools/perf/tests/shell/lib/perf_json_output_lint.py create mode 100755 tools/perf/tests/shell/stat+json_output.sh -- 2.36.1.124.g0e6072fb45-goog