mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Phil Auld <pauld@redhat.com>
To: Valentin Schneider <vschneid@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2 1/2] cpuhp: make target_store() a nop when target == state
Date: Fri, 27 May 2022 09:22:38 -0400	[thread overview]
Message-ID: <20220527132156.GB26124@pauld.bos.csb> (raw)
In-Reply-To: <xhsmhy1ynl3hr.mognet@vschneid.remote.csb>

On Fri, May 27, 2022 at 10:38:24AM +0100 Valentin Schneider wrote:
> On 26/05/22 12:06, Phil Auld wrote:
> > writing the current state back in hotplug/target calls cpu_down()
> > which will set cpu dying even when it isn't and then nothing will
> > ever clear it. A stress test that reads values and writes them back
> > for all cpu device files in sysfs will trigger the BUG() in
> > select_fallback_rq once all cpus are marked as dying.
> >
> > kernel/cpu.c::target_store()
> > 	...
> >         if (st->state < target)
> >                 ret = cpu_up(dev->id, target);
> >         else
> >                 ret = cpu_down(dev->id, target);
> >
> > cpu_down() -> cpu_set_state()
> > 	 bool bringup = st->state < target;
> > 	 ...
> > 	 if (cpu_dying(cpu) != !bringup)
> > 		set_cpu_dying(cpu, !bringup);
> >
> > Fix this by letting state==target fall through in the target_store()
> > conditional.
> >
> 
> To go back on my data race paranoia: writes to both cpu$x/online and
> cpu$x/hotplug/target are serialized by device_hotplug_lock, and so are the
> exported kernel hotplug functions ({add, remove}_cpu()).
> 
> That's not cpu_add_remove_lock as I was looking for, but that's still all
> under one lock, so I think we're good. Sorry for that!
> 

Right. This catches it up higher so that we don't get into the code that
starts actually changing things.  I wonder now in the state == target case
if we should make sure st->target == target.  With the second patch it's 
less likely to be needed. Thoughts?

Maybe I'll include that if/when I have code to keep cpux/online in sync
with st->state and cpu_online_mask.

> > Signed-off-by: Phil Auld <pauld@redhat.com>
> 
> Reviewed-by: Valentin Schneider <vschneid@redhat.com>

Thanks!


Cheers,
Phil


> 
> > ---
> >  kernel/cpu.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/cpu.c b/kernel/cpu.c
> > index d0a9aa0b42e8..cdb6ac10ad94 100644
> > --- a/kernel/cpu.c
> > +++ b/kernel/cpu.c
> > @@ -2315,7 +2315,7 @@ static ssize_t target_store(struct device *dev, struct device_attribute *attr,
> >  
> >  	if (st->state < target)
> >  		ret = cpu_up(dev->id, target);
> > -	else
> > +	else if (st->state > target)
> >  		ret = cpu_down(dev->id, target);
> >  out:
> >  	unlock_device_hotplug();
> > -- 
> > 2.18.0
> 

-- 


  reply	other threads:[~2022-05-27 13:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 16:06 [PATCH v2 0/2] cpuhp: fix some st->target issues Phil Auld
2022-05-26 16:06 ` [PATCH v2 1/2] cpuhp: make target_store() a nop when target == state Phil Auld
2022-05-27  9:38   ` Valentin Schneider
2022-05-27 13:22     ` Phil Auld [this message]
2022-05-30 12:27       ` Valentin Schneider
2022-06-01 15:49         ` Phil Auld
2022-06-01 16:39           ` Valentin Schneider
2022-05-26 16:06 ` [PATCH v2 2/2] cpuhp: Set cpuhp target for boot cpu Phil Auld
2022-05-27  9:38   ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220527132156.GB26124@pauld.bos.csb \
    --to=pauld@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®