From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A34BBC433F5 for ; Mon, 30 May 2022 14:47:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241130AbiE3Oo6 (ORCPT ); Mon, 30 May 2022 10:44:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241470AbiE3OXE (ORCPT ); Mon, 30 May 2022 10:23:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F593A88AC; Mon, 30 May 2022 06:50:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 853F9B80DE4; Mon, 30 May 2022 13:50:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2AEBC385B8; Mon, 30 May 2022 13:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653918624; bh=HfhA/knPQTpMiHWJlc5Vf4P0adQ04PVGMNIykT5zzJk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sEQHFtOuawo5uc5s8gzQ1IIU6N1cpy6VCDbF4ZU5gpn/kkYWJkynQ3wOvWGsjdwvW BOsws60YFA8U4JxJaiB+Z1lOCy7Af+FrYdddcGnchzc10jX7GGVupReDI+x+Om2eh+ //xBFJo+Z/fDy/+11r5wuk7tnGqctXL6Kl0bPanapbwQD+Hrasj0hy82aRIoRIlO4q uFJeJDWuctOxLVU7eUTXCEtKBmSCeLV4fZcjmpf/zu9X2pZ/TbQ9Pv/NrxCcSuqNp8 ULUZ8txV4UIAHXoD2TzaNmB3uAzt3Ktllo+M6RcxCw+WwJM9dV0fF2TZjBSdPdSQlV c4cNhZBXiCUqw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Eric Dumazet , "David S . Miller" , Sasha Levin , kuba@kernel.org, pabeni@redhat.com, bigeasy@linutronix.de, imagedong@tencent.com, petrm@nvidia.com, memxor@gmail.com, arnd@arndb.de, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 24/38] net: remove two BUG() from skb_checksum_help() Date: Mon, 30 May 2022 09:49:10 -0400 Message-Id: <20220530134924.1936816-24-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220530134924.1936816-1-sashal@kernel.org> References: <20220530134924.1936816-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet [ Upstream commit d7ea0d9df2a6265b2b180d17ebc64b38105968fc ] I have a syzbot report that managed to get a crash in skb_checksum_help() If syzbot can trigger these BUG(), it makes sense to replace them with more friendly WARN_ON_ONCE() since skb_checksum_help() can instead return an error code. Note that syzbot will still crash there, until real bug is fixed. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/core/dev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 42f6ff8b9703..b2fc3884a8f4 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2918,11 +2918,15 @@ int skb_checksum_help(struct sk_buff *skb) } offset = skb_checksum_start_offset(skb); - BUG_ON(offset >= skb_headlen(skb)); + ret = -EINVAL; + if (WARN_ON_ONCE(offset >= skb_headlen(skb))) + goto out; + csum = skb_checksum(skb, offset, skb->len - offset, 0); offset += skb->csum_offset; - BUG_ON(offset + sizeof(__sum16) > skb_headlen(skb)); + if (WARN_ON_ONCE(offset + sizeof(__sum16) > skb_headlen(skb))) + goto out; if (skb_cloned(skb) && !skb_clone_writable(skb, offset + sizeof(__sum16))) { -- 2.35.1