From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4812FC433EF for ; Wed, 1 Jun 2022 12:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237112AbiFAMHw (ORCPT ); Wed, 1 Jun 2022 08:07:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbiFAMHu (ORCPT ); Wed, 1 Jun 2022 08:07:50 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9F66A5712C for ; Wed, 1 Jun 2022 05:07:47 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5EA1F1FB; Wed, 1 Jun 2022 05:07:47 -0700 (PDT) Received: from bogus (unknown [10.57.9.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9B3E93F73D; Wed, 1 Jun 2022 05:07:45 -0700 (PDT) Date: Wed, 1 Jun 2022 13:06:58 +0100 From: Sudeep Holla To: Gavin Shan Cc: linux-kernel@vger.kernel.org, Atish Patra , Atish Patra , Sudeep Holla , Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Qing Wang , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Rob Herring Subject: Re: [PATCH v3 09/16] arch_topology: Drop LLC identifier stash from the CPU topology Message-ID: <20220601120658.2x737nhyxmodoo7t@bogus> References: <20220525081416.3306043-2-sudeep.holla@arm.com> <20220525081416.3306043-3-sudeep.holla@arm.com> <20220525081416.3306043-4-sudeep.holla@arm.com> <20220525081416.3306043-5-sudeep.holla@arm.com> <20220525081416.3306043-6-sudeep.holla@arm.com> <20220525081416.3306043-7-sudeep.holla@arm.com> <20220525081416.3306043-8-sudeep.holla@arm.com> <20220525081416.3306043-9-sudeep.holla@arm.com> <20220525081416.3306043-10-sudeep.holla@arm.com> <3860bfcc-a323-c031-0fdd-77001d338bec@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3860bfcc-a323-c031-0fdd-77001d338bec@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 01, 2022 at 11:35:20AM +0800, Gavin Shan wrote: > Hi Sudeep, > > On 5/25/22 4:14 PM, Sudeep Holla wrote: > > Since the cacheinfo LLC information is used directly in arch_topology, > > there is no need to parse and store the LLC ID information only for > > ACPI systems in the CPU topology. > > > > Remove the redundant LLC ID from the generic CPU arch_topology information. > > > > Signed-off-by: Sudeep Holla > > --- > > drivers/base/arch_topology.c | 1 - > > include/linux/arch_topology.h | 1 - > > 2 files changed, 2 deletions(-) > > > > How about merge the changes to PATCH[08/16]? I don't see why we need put > the changes into separate patches. > It took a while to remember as I was with the same opinion as yours but decided to split them for one reason: to keep arch specific change in a separate patch(if that becomes a need due to some conflict or some other non-technical reason) -- Regards, Sudeep