From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 442DBC433EF for ; Wed, 1 Jun 2022 12:46:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237009AbiFAMp7 (ORCPT ); Wed, 1 Jun 2022 08:45:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353022AbiFAMpx (ORCPT ); Wed, 1 Jun 2022 08:45:53 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5E00E4A91D for ; Wed, 1 Jun 2022 05:45:51 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B3F9ED1; Wed, 1 Jun 2022 05:45:51 -0700 (PDT) Received: from bogus (unknown [10.57.9.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0D5863F73D; Wed, 1 Jun 2022 05:45:48 -0700 (PDT) Date: Wed, 1 Jun 2022 13:45:01 +0100 From: Sudeep Holla To: Gavin Shan Cc: linux-kernel@vger.kernel.org, Atish Patra , Atish Patra , Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Qing Wang , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Rob Herring Subject: Re: [PATCH v3 02/16] cacheinfo: Add helper to access any cache index for a given CPU Message-ID: <20220601124501.v4ylb4oqs4uq2oxj@bogus> References: <20220525081416.3306043-1-sudeep.holla@arm.com> <20220525081416.3306043-2-sudeep.holla@arm.com> <20220525081416.3306043-3-sudeep.holla@arm.com> <9a70f2b2-e45c-b125-1c14-d5a06097be58@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a70f2b2-e45c-b125-1c14-d5a06097be58@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 01, 2022 at 10:44:20AM +0800, Gavin Shan wrote: > Hi Sudeep, > > On 5/25/22 4:14 PM, Sudeep Holla wrote: > > The cacheinfo for a given CPU at a given index is used at quite a few > > places by fetching the base point for index 0 using the helper > > per_cpu_cacheinfo(cpu) and offseting it by the required index. > > > > Instead, add another helper to fetch the required pointer directly and > > use it to simplify and improve readability. > > > > Signed-off-by: Sudeep Holla > > --- > > drivers/base/cacheinfo.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > s/offseting/offsetting > > It looks good to me with below nits fixed: > > Reviewed-by: Gavin Shan > > > > diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c > > index b0bde272e2ae..c4547d8ac6f3 100644 > > --- a/drivers/base/cacheinfo.c > > +++ b/drivers/base/cacheinfo.c > > @@ -25,6 +25,8 @@ static DEFINE_PER_CPU(struct cpu_cacheinfo, ci_cpu_cacheinfo); > > #define ci_cacheinfo(cpu) (&per_cpu(ci_cpu_cacheinfo, cpu)) > > #define cache_leaves(cpu) (ci_cacheinfo(cpu)->num_leaves) > > #define per_cpu_cacheinfo(cpu) (ci_cacheinfo(cpu)->info_list) > > +#define per_cpu_cacheinfo_idx(cpu, idx) \ > > + (per_cpu_cacheinfo(cpu) + (idx)) > > struct cpu_cacheinfo *get_cpu_cacheinfo(unsigned int cpu) > > { > > @@ -172,7 +174,7 @@ static int cache_setup_of_node(unsigned int cpu) > > } > > while (index < cache_leaves(cpu)) { > > - this_leaf = this_cpu_ci->info_list + index; > > + this_leaf = per_cpu_cacheinfo_idx(cpu, index); > > if (this_leaf->level != 1) > > np = of_find_next_cache_node(np); > > else > > @@ -231,7 +233,7 @@ static int cache_shared_cpu_map_setup(unsigned int cpu) > > for (index = 0; index < cache_leaves(cpu); index++) { > > unsigned int i; > > - this_leaf = this_cpu_ci->info_list + index; > > + this_leaf = per_cpu_cacheinfo_idx(cpu, index); > > /* skip if shared_cpu_map is already populated */ > > if (!cpumask_empty(&this_leaf->shared_cpu_map)) > > continue; > > @@ -242,7 +244,7 @@ static int cache_shared_cpu_map_setup(unsigned int cpu) > > if (i == cpu || !sib_cpu_ci->info_list) > > continue;/* skip if itself or no cacheinfo */ > > - sib_leaf = sib_cpu_ci->info_list + index; > > + sib_leaf = per_cpu_cacheinfo_idx(i, index); > > if (cache_leaves_are_shared(this_leaf, sib_leaf)) { > > cpumask_set_cpu(cpu, &sib_leaf->shared_cpu_map); > > cpumask_set_cpu(i, &this_leaf->shared_cpu_map); > > @@ -258,12 +260,11 @@ static int cache_shared_cpu_map_setup(unsigned int cpu) > > static void cache_shared_cpu_map_remove(unsigned int cpu) > > { > > - struct cpu_cacheinfo *this_cpu_ci = get_cpu_cacheinfo(cpu); > > struct cacheinfo *this_leaf, *sib_leaf; > > unsigned int sibling, index; > > for (index = 0; index < cache_leaves(cpu); index++) { > > - this_leaf = this_cpu_ci->info_list + index; > > + this_leaf = per_cpu_cacheinfo_idx(cpu, index); > > for_each_cpu(sibling, &this_leaf->shared_cpu_map) { > > struct cpu_cacheinfo *sib_cpu_ci; > > > > In cache_shared_cpu_map_remove(), the newly introduced macro > can be applied when the sibling CPU's cache info is fetched. > > sib_leaf = sib_cpu_ci->info_list + index; > > to > > sib_leaf = per_cpu_cacheinfo_idx(sibling, index); > Right, I clearly missed to identify this. Thanks again for the review, all other comments are now fixed locally and pushed @[1], will post them as part of next version. -- Regards, Sudeep [1] https://git.kernel.org/sudeep.holla/h/arch_topology