From: Maxime Ripard <maxime@cerno.tech>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: laurent.pinchart@ideasonboard.com, andrzej.hajda@intel.com,
narmstrong@baylibre.com, robert.foss@linaro.org, jonas@kwiboo.se,
jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
sam@ravnborg.org, alsi@bang-olufsen.dk,
jagan@amarulasolutions.com, biju.das.jz@bp.renesas.com,
l.stach@pengutronix.de, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: bridge: adv7511: Add check for mipi_dsi_driver_register
Date: Thu, 2 Jun 2022 10:40:37 +0200 [thread overview]
Message-ID: <20220602084037.c2pslwra4dyhnh3d@penduick> (raw)
In-Reply-To: <20220601111255.2911012-1-jiasheng@iscas.ac.cn>
On Wed, Jun 01, 2022 at 07:12:55PM +0800, Jiasheng Jiang wrote:
> On Wed, Jun 01, 2022 at 05:15:37PM +0800, Laurent Pinchart wrote:
> >> Well, as far as I am concerned, the adv7511_exit() in the same file has already dealt with the issue.
> >> Therefore, it might not be necessary to add another mipi_dsi_driver_unregister().
> >
> > The issue is that adv7511_exit() is not called if adv7511_init() fails.
>
> Sorry, I can not find the caller of adv7511_init().
> Please give me more detail.
It's called by the kernel when the module is unloaded (module_exit).
It's not what Laurent is saying though.
His point is that in adv7511, if i2c_add_driver fails, you'll still need
to call mipi_dsi_driver_unregister to clean things up.
Maxime
next prev parent reply other threads:[~2022-06-02 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 11:12 Jiasheng Jiang
2022-06-02 8:40 ` Maxime Ripard [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-01 2:48 Jiasheng Jiang
2022-06-01 6:52 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602084037.c2pslwra4dyhnh3d@penduick \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=alsi@bang-olufsen.dk \
--cc=andrzej.hajda@intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jiasheng@iscas.ac.cn \
--cc=jonas@kwiboo.se \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®