From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19151C43334 for ; Thu, 2 Jun 2022 16:21:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236983AbiFBQV4 (ORCPT ); Thu, 2 Jun 2022 12:21:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236945AbiFBQVa (ORCPT ); Thu, 2 Jun 2022 12:21:30 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93E092AD989 for ; Thu, 2 Jun 2022 09:21:29 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 252Ao5gE026091; Thu, 2 Jun 2022 11:21:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=BOGFGJu5wzq9lAKUjsSDYjYbucMgtUxVYgWRIpxRVys=; b=MBvlgfKQclbHZiUJDC25dAMnBTaUokpcWolklk0I2PbFQQLGsisVDeKa8E5NP5cYlvtS NCKyzw41sBkvLT7qaFeezJDJBSAufIHa94B6XTt+h+B8fK9Ix/ElAXz/Cu6cSKBVMht4 vxPMkSA7KYcMXg3Zz3g5r+GyowcJVop4WitaLUj+jIbgVDo5wCnFGaSQTEFKiHEHdGLx OOJn9iMUUien0QgqwHcmVe26s5k82B++pcWZ2gKUxyX534y0RLwsYaaQD+TK1J0w1p/f bSjG1ll14u1lbibF31kOxRhJONWlBTDTkWIg4jJ3ADgjpCC97206YEgEPefsCSUTBeMG nw== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3gbh51nq0d-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 02 Jun 2022 11:21:23 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 2 Jun 2022 17:21:19 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 2 Jun 2022 17:21:19 +0100 Received: from algalon.ad.cirrus.com (algalon.ad.cirrus.com [198.90.251.122]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 66C2E11D1; Thu, 2 Jun 2022 16:21:19 +0000 (UTC) From: Charles Keepax To: CC: , , , , , Subject: [PATCH 6/6] ASoC: cs42l51: Correct minimum value for SX volume control Date: Thu, 2 Jun 2022 17:21:19 +0100 Message-ID: <20220602162119.3393857-7-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220602162119.3393857-1-ckeepax@opensource.cirrus.com> References: <20220602162119.3393857-1-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: 4y5yNcRhOdjaoQmqu9XYkfoP1b5r9OpT X-Proofpoint-ORIG-GUID: 4y5yNcRhOdjaoQmqu9XYkfoP1b5r9OpT X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The minimum value for the PGA Volume is given as 0x1A, however the values from there to 0x19 are all the same volume and this is not represented in the TLV structure. The number of volumes given is correct so this leads to all the volumes being shifted. Move the minimum value up to 0x19 to fix this. Signed-off-by: Charles Keepax --- sound/soc/codecs/cs42l51.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs42l51.c b/sound/soc/codecs/cs42l51.c index aff618513c753..0e933181b5dbb 100644 --- a/sound/soc/codecs/cs42l51.c +++ b/sound/soc/codecs/cs42l51.c @@ -143,7 +143,7 @@ static const struct snd_kcontrol_new cs42l51_snd_controls[] = { 0, 0xA0, 96, adc_att_tlv), SOC_DOUBLE_R_SX_TLV("PGA Volume", CS42L51_ALC_PGA_CTL, CS42L51_ALC_PGB_CTL, - 0, 0x1A, 30, pga_tlv), + 0, 0x19, 30, pga_tlv), SOC_SINGLE("Playback Deemphasis Switch", CS42L51_DAC_CTL, 3, 1, 0), SOC_SINGLE("Auto-Mute Switch", CS42L51_DAC_CTL, 2, 1, 0), SOC_SINGLE("Soft Ramp Switch", CS42L51_DAC_CTL, 1, 1, 0), -- 2.30.2