From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B43C2C433EF for ; Sun, 5 Jun 2022 10:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351005AbiFEKdi (ORCPT ); Sun, 5 Jun 2022 06:33:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245542AbiFEKd0 (ORCPT ); Sun, 5 Jun 2022 06:33:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B90B520F42 for ; Sun, 5 Jun 2022 03:33:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 62E85B80B8A for ; Sun, 5 Jun 2022 10:33:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D413C3411C; Sun, 5 Jun 2022 10:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654425203; bh=rc2zsORGj01zJ5Lz9EoBugxqUE8xMq+JOutnPoIXF+U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tsUL65MJsA9+ci1WOLgi36ARNWfkehBbrCyocImJ1McQhL9rwx3Iq/Q7/v5mkKZo9 oTvkv5cXBQhwnf8D7iadS9o8nnfe9+rn1W2Je0gmVsHPqKcb7f7tRsuRP+xwsVfyD7 +FmpsjxALTy8vuwF8Ec5OJ8cIJ9+P/n6AS7X96XR4aNKLB5x1Oa/Yie/Y7GvFMMFKr cCrI0N3kpSVkrpf0EO6QZPBcv/ajBwWwVkOZqC8JhPh13Gdxal223y8G5IW9mAqUPC O2LbapNjeZAi5Sj2Zd1rA4AxuaBPfsX+CT8BFa5fsi08uzNaDTNZ/abjOJHjRpecXm y+rjrLTzibVCA== From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: Dan Rapaport Subject: [PATCH 2/7] habanalabs: align ioctl uapi structures to 64-bit Date: Sun, 5 Jun 2022 13:33:11 +0300 Message-Id: <20220605103316.3414541-2-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220605103316.3414541-1-ogabbay@kernel.org> References: <20220605103316.3414541-1-ogabbay@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Rapaport The compiler is padding the members of the struct to be aligned to 64-bit. The content of the padded bytes is and not zeroed explicitly, hence might copy undefined data. We add a padding member to the struct to get a zeroed 64-bit align struct. Signed-off-by: Dan Rapaport Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- include/uapi/misc/habanalabs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/misc/habanalabs.h b/include/uapi/misc/habanalabs.h index 52540d5b4fc9..6d2ccc09dcf2 100644 --- a/include/uapi/misc/habanalabs.h +++ b/include/uapi/misc/habanalabs.h @@ -949,6 +949,7 @@ struct hl_cs_in { /* Context ID - Currently not in use */ __u32 ctx_id; + __u8 pad[4]; }; struct hl_cs_out { -- 2.25.1