mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [peterz-queue:sched/idle 5/33] drivers/idle/intel_idle.c:134: warning: expecting prototype for intel_idle(). Prototype was for __intel_idle() instead
Date: Mon, 6 Jun 2022 01:01:20 +0800	[thread overview]
Message-ID: <202206060056.fqu4UFgZ-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/idle
head:   5aca393851ce7ebb9a3405bb4ffd4f38d96949e4
commit: 625fb75b0c1feec90c70e69c722cb6df86ff3631 [5/33] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE
config: i386-debian-10.3-kselftests (https://download.01.org/0day-ci/archive/20220606/202206060056.fqu4UFgZ-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=625fb75b0c1feec90c70e69c722cb6df86ff3631
        git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
        git fetch --no-tags peterz-queue sched/idle
        git checkout 625fb75b0c1feec90c70e69c722cb6df86ff3631
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/idle/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/idle/intel_idle.c:134: warning: expecting prototype for intel_idle(). Prototype was for __intel_idle() instead


vim +134 drivers/idle/intel_idle.c

b1beab48f6148d Len Brown         2013-01-31  117  
30a996fbb359ed Rafael J. Wysocki 2020-02-06  118  /**
30a996fbb359ed Rafael J. Wysocki 2020-02-06  119   * intel_idle - Ask the processor to enter the given idle state.
30a996fbb359ed Rafael J. Wysocki 2020-02-06  120   * @dev: cpuidle device of the target CPU.
30a996fbb359ed Rafael J. Wysocki 2020-02-06  121   * @drv: cpuidle driver (assumed to point to intel_idle_driver).
30a996fbb359ed Rafael J. Wysocki 2020-02-06  122   * @index: Target idle state index.
30a996fbb359ed Rafael J. Wysocki 2020-02-06  123   *
30a996fbb359ed Rafael J. Wysocki 2020-02-06  124   * Use the MWAIT instruction to notify the processor that the CPU represented by
30a996fbb359ed Rafael J. Wysocki 2020-02-06  125   * @dev is idle and it can try to enter the idle state corresponding to @index.
30a996fbb359ed Rafael J. Wysocki 2020-02-06  126   *
30a996fbb359ed Rafael J. Wysocki 2020-02-06  127   * If the local APIC timer is not known to be reliable in the target idle state,
30a996fbb359ed Rafael J. Wysocki 2020-02-06  128   * enable one-shot tick broadcasting for the target CPU before executing MWAIT.
30a996fbb359ed Rafael J. Wysocki 2020-02-06  129   *
30a996fbb359ed Rafael J. Wysocki 2020-02-06  130   * Must be called under local_irq_disable().
30a996fbb359ed Rafael J. Wysocki 2020-02-06  131   */
625fb75b0c1fee Peter Zijlstra    2022-06-02  132  static __always_inline int __intel_idle(struct cpuidle_device *dev,
30a996fbb359ed Rafael J. Wysocki 2020-02-06  133  					struct cpuidle_driver *drv, int index)
30a996fbb359ed Rafael J. Wysocki 2020-02-06 @134  {
30a996fbb359ed Rafael J. Wysocki 2020-02-06  135  	struct cpuidle_state *state = &drv->states[index];
30a996fbb359ed Rafael J. Wysocki 2020-02-06  136  	unsigned long eax = flg2MWAIT(state->flags);
30a996fbb359ed Rafael J. Wysocki 2020-02-06  137  	unsigned long ecx = 1; /* break on interrupt flag */
30a996fbb359ed Rafael J. Wysocki 2020-02-06  138  
30a996fbb359ed Rafael J. Wysocki 2020-02-06  139  	mwait_idle_with_hints(eax, ecx);
30a996fbb359ed Rafael J. Wysocki 2020-02-06  140  
30a996fbb359ed Rafael J. Wysocki 2020-02-06  141  	return index;
30a996fbb359ed Rafael J. Wysocki 2020-02-06  142  }
30a996fbb359ed Rafael J. Wysocki 2020-02-06  143  

:::::: The code at line 134 was first introduced by commit
:::::: 30a996fbb359ed53536a055af84a54223beabf91 intel_idle: Relocate definitions of cpuidle callbacks

:::::: TO: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-06-05 17:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202206060056.fqu4UFgZ-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®