mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: bleung@chromium.org, groeck@chromium.org
Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 12/13] platform/chrome: cros_ec_proto: arrange get_host_event_wake_mask()
Date: Mon,  6 Jun 2022 14:10:50 +0000	[thread overview]
Message-ID: <20220606141051.285823-13-tzungbi@kernel.org> (raw)
In-Reply-To: <20220606141051.285823-1-tzungbi@kernel.org>

- cros_ec_get_host_event_wake_mask() is a private (static) function.
  Rename it to get_host_event_wake_mask().

- Join multiple lines into one if it can fit in 100 columns.

Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
 drivers/platform/chrome/cros_ec_proto.c      | 9 ++++-----
 drivers/platform/chrome/cros_ec_proto_test.c | 8 ++++----
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
index 91c945c9911f..1622e24747c9 100644
--- a/drivers/platform/chrome/cros_ec_proto.c
+++ b/drivers/platform/chrome/cros_ec_proto.c
@@ -230,7 +230,7 @@ int cros_ec_check_result(struct cros_ec_device *ec_dev,
 EXPORT_SYMBOL(cros_ec_check_result);
 
 /*
- * cros_ec_get_host_event_wake_mask
+ * get_host_event_wake_mask
  *
  * Get the mask of host events that cause wake from suspend.
  *
@@ -242,7 +242,7 @@ EXPORT_SYMBOL(cros_ec_check_result);
  * the caller has ec_dev->lock mutex, or the caller knows there is
  * no other command in progress.
  */
-static int cros_ec_get_host_event_wake_mask(struct cros_ec_device *ec_dev, uint32_t *mask)
+static int get_host_event_wake_mask(struct cros_ec_device *ec_dev, uint32_t *mask)
 {
 	struct cros_ec_command *msg;
 	struct ec_response_host_event_mask *r;
@@ -498,7 +498,7 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev)
 	ec_dev->host_sleep_v1 = (ret > 0 && (ver_mask & EC_VER_MASK(1)));
 
 	/* Get host event wake mask. */
-	ret = cros_ec_get_host_event_wake_mask(ec_dev, &ec_dev->host_event_wake_mask);
+	ret = get_host_event_wake_mask(ec_dev, &ec_dev->host_event_wake_mask);
 	if (ret < 0) {
 		/*
 		 * If the EC doesn't support EC_CMD_HOST_EVENT_GET_WAKE_MASK,
@@ -522,8 +522,7 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev)
 		 * other errors.
 		 */
 		if (ret != -EOPNOTSUPP)
-			dev_err(ec_dev->dev,
-				"failed to retrieve wake mask: %d\n", ret);
+			dev_err(ec_dev->dev, "failed to retrieve wake mask: %d\n", ret);
 	}
 
 	return 0;
diff --git a/drivers/platform/chrome/cros_ec_proto_test.c b/drivers/platform/chrome/cros_ec_proto_test.c
index 7d73aeb99d1d..f63196289f54 100644
--- a/drivers/platform/chrome/cros_ec_proto_test.c
+++ b/drivers/platform/chrome/cros_ec_proto_test.c
@@ -239,7 +239,7 @@ static void cros_ec_proto_test_query_all_normal(struct kunit *test)
 		data->version_mask = BIT(1);
 	}
 
-	/* For cros_ec_get_host_event_wake_mask(). */
+	/* For get_host_event_wake_mask(). */
 	{
 		struct ec_response_host_event_mask *data;
 
@@ -326,7 +326,7 @@ static void cros_ec_proto_test_query_all_normal(struct kunit *test)
 		KUNIT_EXPECT_TRUE(test, ec_dev->host_sleep_v1);
 	}
 
-	/* For cros_ec_get_host_event_wake_mask(). */
+	/* For get_host_event_wake_mask(). */
 	{
 		mock = cros_kunit_ec_xfer_mock_next();
 		KUNIT_EXPECT_PTR_NE(test, mock, NULL);
@@ -915,7 +915,7 @@ static void cros_ec_proto_test_query_all_default_wake_mask(struct kunit *test)
 		KUNIT_ASSERT_PTR_NE(test, mock, NULL);
 	}
 
-	/* For cros_ec_get_host_event_wake_mask(). */
+	/* For get_host_event_wake_mask(). */
 	{
 		mock = cros_kunit_ec_xfer_mock_addx(test, 0, EC_RES_INVALID_COMMAND,
 						    sizeof(struct ec_response_host_event_mask));
@@ -976,7 +976,7 @@ static void cros_ec_proto_test_query_all_default_wake_mask(struct kunit *test)
 		KUNIT_EXPECT_EQ(test, mock->msg.outsize, sizeof(struct ec_params_get_cmd_versions));
 	}
 
-	/* For cros_ec_get_host_event_wake_mask(). */
+	/* For get_host_event_wake_mask(). */
 	{
 		u32 mask;
 
-- 
2.36.1.255.ge46751e96f-goog


  parent reply	other threads:[~2022-06-06 14:13 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 14:10 [PATCH 00/13] platform/chrome: Kunit tests and refactor for cros_ec_query_all() Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 01/13] platform/chrome: cros_ec_commands: fix compile errors Tzung-Bi Shih
2022-06-06 15:08   ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 02/13] platform/chrome: cros_ec_proto: add Kunit tests for cros_ec_query_all() Tzung-Bi Shih
2022-06-06 15:18   ` Guenter Roeck
2022-06-07  0:54     ` Tzung-Bi Shih
2022-06-07 14:41       ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 03/13] platform/chrome: use macros for passthru indexes Tzung-Bi Shih
2022-06-06 15:22   ` Guenter Roeck
2022-06-06 15:23     ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 04/13] platform/chrome: cros_ec_proto: assign buffer size from protocol info Tzung-Bi Shih
2022-06-06 15:24   ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 05/13] platform/chrome: cros_ec_proto: remove redundant NULL check Tzung-Bi Shih
2022-06-06 15:46   ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 06/13] platform/chrome: cros_ec_proto: use cros_ec_map_error() Tzung-Bi Shih
2022-06-06 15:55   ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 07/13] platform/chrome: cros_ec_proto: separate fill_protocol_info() Tzung-Bi Shih
2022-06-06 16:06   ` Guenter Roeck
2022-06-07  0:54     ` Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 08/13] platform/chrome: cros_ec_proto: separate fill_protocol_info_legacy() Tzung-Bi Shih
2022-06-06 16:06   ` Guenter Roeck
2022-06-07  0:55     ` Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 09/13] platform/chrome: cros_ec_proto: use devm_krealloc() Tzung-Bi Shih
2022-06-06 16:04   ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 10/13] platform/chrome: cros_ec_proto: arrange get_host_command_version_mask() Tzung-Bi Shih
2022-06-06 16:09   ` Guenter Roeck
2022-06-07  0:55     ` Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 11/13] platform/chrome: cros_ec_proto: fix get_host_command_version_mask() returns Tzung-Bi Shih
2022-06-06 16:16   ` Guenter Roeck
2022-06-06 14:10 ` Tzung-Bi Shih [this message]
2022-06-06 16:18   ` [PATCH 12/13] platform/chrome: cros_ec_proto: arrange get_host_event_wake_mask() Guenter Roeck
2022-06-07  0:55     ` Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 13/13] platform/chrome: cros_ec_proto: fix get_host_event_wake_mask() returns Tzung-Bi Shih
2022-06-06 16:14   ` Guenter Roeck
2022-06-07  0:55     ` Tzung-Bi Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220606141051.285823-13-tzungbi@kernel.org \
    --to=tzungbi@kernel.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®