From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5688CC43334 for ; Wed, 8 Jun 2022 15:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244128AbiFHPPb (ORCPT ); Wed, 8 Jun 2022 11:15:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243212AbiFHPOL (ORCPT ); Wed, 8 Jun 2022 11:14:11 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CD7020C243 for ; Wed, 8 Jun 2022 08:06:36 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id d14so19763396wra.10 for ; Wed, 08 Jun 2022 08:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PhrsnkQYF8hJROFLG3oTpTLzsaUl8ukSdrO+5KpRu9o=; b=oNno/0HbthPALtO1PqKOPIaz5DBcFf9pQWt8bZu0u8lxyCMFRn99MmD/7nQpyKYBjW 9z4NkSnmwkbSBCcrMc9tNIZFPojEWX1fUE2Z4l26/61CQ/QJ3t3Dfy8iRwncY8JsrDvW WcGPn0EIk7FDariBsKjKiV8kWPlyVeGGAPvLRVxpqCqCZAfEAEbrUpX0WPh+qa6+hyfS VRibz/A2tn66MQ7M04t1ysEoJCULNws+NqbRP06JhkMEpTtjNSKaaFU7RBBx0X/X+nLR /RQRKZpwczAm6BSqgWxWzNEQwGM3y8g022JdnuH/9iS6cWuNwhlPUqduiSU7NQSa3nvY aT/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PhrsnkQYF8hJROFLG3oTpTLzsaUl8ukSdrO+5KpRu9o=; b=WPBq73CSFxYZs7WaSRqTaMuEuDqL/ZcQzAOT8zbM4XOYJ3L8TRtNGsQCsRN/hxyjyo NLSZhuUIpZ9A1wnklwcZn/BZJZgsOur7bBMyxjGskifRYDcXb21qym0iG34dobNj1hK3 Rx3hGw4c9GKeyEIWa5orK/NPQrfEi/3VJoRAzJVejOpTicCN+/9ne6pLnOIjJhHh9SqM ZZnJFGBhsHP7A989adh8LH1MtJjeqSmK5ve5r1EM30L52vg/9SkjbSJOt/VLpdZkcg8j 8d5ekCzJBmLdWAcdVgE55eozwaex0aW1anZfsURRpFYyfvCeAXvXWSSJzrj+XQXbP7iR GQWQ== X-Gm-Message-State: AOAM532ULn8yYIVOprddOJ2UUuM/Wgu3NIWwb+54YJrVRpPha2eLZYmc MHiBEYyYF18qgovSuiwW/Giz9A== X-Google-Smtp-Source: ABdhPJw2zbIWGQqQEdA8aTNGLbz3Y44qF4XhRLn2zSheJU7Rky18ZqbW4vt8p/Wq7OYg6zhHflIsxw== X-Received: by 2002:a5d:6f1c:0:b0:213:d715:d09f with SMTP id ay28-20020a5d6f1c000000b00213d715d09fmr28589518wrb.275.1654700794698; Wed, 08 Jun 2022 08:06:34 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id t22-20020a05600c41d600b00397550b387bsm28672852wmh.23.2022.06.08.08.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 08:06:34 -0700 (PDT) Date: Wed, 8 Jun 2022 16:06:32 +0100 From: Daniel Thompson To: Stephen Kitt Cc: "Lee, Chun-Yi" , Hans de Goede , Mark Gross , Cezary Jackiewicz , Henrique de Moraes Holschuh , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] platform/x86: apple-gmux: Use backlight helper Message-ID: <20220608150632.mnebepml2cply4px@maple.lan> References: <20220607184635.1127913-1-steve@sk2.org> <20220607184635.1127913-3-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607184635.1127913-3-steve@sk2.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2022 at 08:46:33PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Cc: Hans de Goede > Cc: Mark Gross > Cc: platform-driver-x86@vger.kernel.org Reviewed-by: Daniel Thompson Daniel.