From: Stephen Kitt <steve@sk2.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: shmobile: Use backlight helper
Date: Wed, 8 Jun 2022 23:34:55 +0200 [thread overview]
Message-ID: <20220608233455.4d56238e@heffalump.sk2.org> (raw)
In-Reply-To: <YqBK+GXrIx3XX+Km@pendragon.ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
Hi Laurent,
On Wed, 8 Jun 2022 10:08:40 +0300, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Tue, Jun 07, 2022 at 11:05:37PM +0200, Stephen Kitt wrote:
> > On Tue, 7 Jun 2022 20:31:32 +0200, Stephen Kitt <steve@sk2.org> wrote:
> > > backlight_properties.fb_blank is deprecated. The states it represents
> > > are handled by other properties; but instead of accessing those
> > > properties directly, drivers should use the helpers provided by
> > > backlight.h.
> >
> > Apologies for the misleading boilerplate, this patch came about as a
> > result of cleaning up fb_blank usage but doesn't involve fb_blank itself.
> >
>
> No worries. Would you like to submit a v2 with a better commit message ?
> The patch otherwise looks good to me.
Yes, I’ll do that.
Thanks,
Stephen
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-06-08 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 18:31 Stephen Kitt
2022-06-07 21:05 ` Stephen Kitt
2022-06-08 7:08 ` Laurent Pinchart
2022-06-08 21:34 ` Stephen Kitt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608233455.4d56238e@heffalump.sk2.org \
--to=steve@sk2.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®