From: "Michal Koutný" <mkoutny@suse.com>
To: Tadeusz Struk <tadeusz.struk@linaro.org>
Cc: kernel test robot <oliver.sang@intel.com>,
0day robot <lkp@intel.com>, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Christian Brauner <brauner@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
cgroups@vger.kernel.org, lkp@lists.01.org,
netdev@vger.kernel.org, bpf@vger.kernel.org,
stable@vger.kernel.org,
syzbot+e42ae441c3b10acf9e9d@syzkaller.appspotmail.com
Subject: Re: [cgroup] 3c87862ca1: WARNING:at_kernel/softirq.c:#__local_bh_enable_ip
Date: Thu, 9 Jun 2022 16:55:49 +0200 [thread overview]
Message-ID: <20220609145549.GA28484@blackbody.suse.cz> (raw)
In-Reply-To: <b39cdb9c-aa2a-0f49-318b-8632b2989433@linaro.org>
Hello Tadeusz.
On Thu, Jun 09, 2022 at 07:30:41AM -0700, Tadeusz Struk <tadeusz.struk@linaro.org> wrote:
> Are you interested in fixing this at syzbot issue all?
The (original) syzbot report is conditioned by allocation failure that's
unlikely under normal conditions (AFAIU). Hence I don't treat it extra
high urgent.
OTOH, it's interesting and it points to some disparity worth fixing --
so I try helping (as time permits, so far I can only run the reproducers
via the syzbot).
> Do you have any more feedback on this?
Ad the patch v2 with spinlock per css -- that looks like an overkill to
me, I didn't look deeper into it.
Ad the in-thread patch with ancestry css_get(), the ->parent ref:
- is inc'd in init_and_link_css(),
- is dec'd in css_free_rwork_fn()
and thanks to ->online_cnt offlining is ordered (child before parent).
Where does your patch dec these ancestry references? (Or why would they
be missing in the first place?)
Thanks for digging into this!
Michal
prev parent reply other threads:[~2022-06-09 14:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 17:34 [PATCH] cgroup: serialize css kill and release paths Tadeusz Struk
2022-06-03 18:06 ` Tadeusz Struk
2022-06-03 18:13 ` [PATCH v2] " Tadeusz Struk
2022-06-03 18:17 ` Tadeusz Struk
2022-06-06 12:39 ` Michal Koutný
2022-06-07 18:47 ` Tadeusz Struk
2022-06-09 8:56 ` [cgroup] 3c87862ca1: WARNING:at_kernel/softirq.c:#__local_bh_enable_ip kernel test robot
2022-06-09 14:30 ` Tadeusz Struk
2022-06-09 14:55 ` Michal Koutný [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609145549.GA28484@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hannes@cmpxchg.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+e42ae441c3b10acf9e9d@syzkaller.appspotmail.com \
--cc=tadeusz.struk@linaro.org \
--cc=tj@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®