From: Marijn Suijten <marijn.suijten@somainline.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: phone-devel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Rajeev Nandan <quic_rajeevny@quicinc.com>,
Vladimir Lypak <vladimir.lypak@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Jonathan Marek <jonathan@marek.ca>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v2 04/11] drm/msm/dsi/phy: Reindent and reflow multiline function calls
Date: Fri, 10 Jun 2022 09:35:47 +0200 [thread overview]
Message-ID: <20220610073547.meftbrcxk274kxhq@SoMainline.org> (raw)
In-Reply-To: <CAA8EJpqU6y3YKfZpgKORCfns-LN81NhqOetQbBC_Z4gVdMQakg@mail.gmail.com>
On 2022-06-02 13:14:26, Dmitry Baryshkov wrote:
> On Thu, 2 Jun 2022 at 01:07, Marijn Suijten
> <marijn.suijten@somainline.org> wrote:
> >
> > Patch 613cbd1da3c9 ("drm/msm/dsi: use devm_clk_*register to registe DSI
> > PHY clocks") introduced the devm_ prefix to clk_hw registration calls,
> > without updating the indentation of the arguments on the following
> > lines.
> >
> > Similarly e55b3fbbbbc8 ("drm/msm/dsi: drop PLL accessor functions")
> > moved from pll_write to dsi_phy_write without updating the indentation
> > of followup arguments either.
> >
> > Preparing for a series that heavily touches the clk calls, reflow and
> > reindent function calls that are adhering to an 80-char column limit by
> > spanning multiple lines. Where function names are very long the
> > arguments are indented with a fixed number of two tab characters instead
> > of aligning with the opening parenthesis of the function call.
> >
>
> I'm not a fan of reindenting the code, but let's do it.
I don't like it either, but it's better than trying to figure out how to
add and flow new arguments into the call-site while also leaving the
indentation in the same broken state. At the same time it seems more
consistent to fix up most faults rather than only touching clk calls.
It's unfortunate that there's no proper autoformatter for C, that is
consistently used across the kernel tree. Makes for a lot of mundane,
error-prone, manual work. But alas.
- Marijn
next prev parent reply other threads:[~2022-06-10 7:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 22:07 [PATCH v2 00/11] drm/msm/dsi_phy: Replace parent names with clk_hw pointers Marijn Suijten
2022-06-01 22:07 ` [PATCH v2 01/11] clk: divider: Introduce devm_clk_hw_register_divider_parent_hw() Marijn Suijten
2022-06-02 10:14 ` Dmitry Baryshkov
2022-06-01 22:07 ` [PATCH v2 02/11] clk: mux: Introduce devm_clk_hw_register_mux_parent_hws() Marijn Suijten
2022-06-02 10:15 ` Dmitry Baryshkov
2022-06-01 22:07 ` [PATCH v2 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw() Marijn Suijten
2022-06-02 10:20 ` Dmitry Baryshkov
2022-06-09 22:12 ` Stephen Boyd
2022-06-10 7:46 ` Marijn Suijten
2022-06-10 19:01 ` Stephen Boyd
2022-06-27 22:36 ` Marijn Suijten
2022-06-01 22:07 ` [PATCH v2 04/11] drm/msm/dsi/phy: Reindent and reflow multiline function calls Marijn Suijten
2022-06-02 10:14 ` Dmitry Baryshkov
2022-06-10 7:35 ` Marijn Suijten [this message]
2022-06-01 22:07 ` [PATCH v2 05/11] drm/msm/dsi_phy_28nm_8960: Use stack memory for temporary clock names Marijn Suijten
2022-06-01 22:07 ` [PATCH v2 06/11] drm/msm/dsi/phy: Replace hardcoded char-array length with sizeof() Marijn Suijten
2022-06-02 9:41 ` Dmitry Baryshkov
2022-06-01 22:07 ` [PATCH v2 07/11] drm/msm/dsi_phy_28nm_8960: Replace parent names with clk_hw pointers Marijn Suijten
2022-06-01 22:07 ` [PATCH v2 08/11] drm/msm/dsi_phy_28nm: " Marijn Suijten
2022-06-02 9:41 ` Dmitry Baryshkov
2022-06-01 22:07 ` [PATCH v2 09/11] drm/msm/dsi_phy_14nm: " Marijn Suijten
2022-06-01 22:07 ` [PATCH v2 10/11] drm/msm/dsi_phy_10nm: " Marijn Suijten
2022-06-01 22:07 ` [PATCH v2 11/11] drm/msm/dsi_phy_7nm: " Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220610073547.meftbrcxk274kxhq@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@somainline.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.botka@somainline.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_rajeevny@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vladimir.lypak@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®