Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

[Stephen Kitt <steve@sk2.org>]

[-- Attachment #1: Type: text/plain, Size: 2414 bytes --]

On Fri, 10 Jun 2022 21:28:32 +0200, Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Stephen.
> On Fri, Jun 10, 2022 at 07:47:20PM +0200, Stephen Kitt wrote:
> > Hi Sebastian,
> > 
> > On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel
> > <sebastian.reichel@collabora.com> wrote:  
> > > On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote:  
> > > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c
> > > > b/drivers/gpu/drm/panel/panel-dsi-cm.c index
> > > > b58cb064975f..aa36dc6cedd3 100644 ---
> > > > a/drivers/gpu/drm/panel/panel-dsi-cm.c +++
> > > > b/drivers/gpu/drm/panel/panel-dsi-cm.c @@ -86,16 +86,10 @@ static
> > > > void dsicm_bl_power(struct panel_drv_data *ddata, bool enable) return;
> > > >  
> > > >  	if (enable) {
> > > > -		backlight->props.fb_blank = FB_BLANK_UNBLANK;
> > > > -		backlight->props.state = ~(BL_CORE_FBBLANK |
> > > > BL_CORE_SUSPENDED);
> > > > -		backlight->props.power = FB_BLANK_UNBLANK;
> > > > +		backlight_enable(backlight);
> > > >  	} else {
> > > > -		backlight->props.fb_blank = FB_BLANK_NORMAL;
> > > > -		backlight->props.power = FB_BLANK_POWERDOWN;
> > > > -		backlight->props.state |= BL_CORE_FBBLANK |
> > > > BL_CORE_SUSPENDED;
> > > > +		backlight_disable(backlight);
> > > >  	}    
> > > 
> > > The brackets can be removed now. Otherwise:  
> >   
> > > 
> > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>  
> > 
> > Thanks, I’ll wait a little more to see if there are any other reviews of
> > the patches and then push a v2 with that fix.  
> It would be very nice if you could kill all uses of FB_BLANK in the
> drivers/gpu/drm/panel/* drivers, and post them as one series.
> This is long overdue to introduce the backlight helpers.
> 
> The three you posted is already a nice step forward, and there may be
> more panel drivers I have missed.

With this series on top of 5.19-rc1, the only remaining .fb_blank reference is
in acx565akm_backlight_init() in panel-sony-acx565akm.c; I was planning on
nuking that along with the other .fb_blank initialisers in a series removing
.fb_blank entirely from backlight_properties. I’ll add it as a fourth patch
for drm/panel if that makes things easier!

There will still be references to FB_BLANK constants since they’re used for
backlight_properties.power values. Would it make sense to rename those?

Regards,

Stephen

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]