From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAD6AC433EF for ; Fri, 10 Jun 2022 20:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347086AbiFJUnj (ORCPT ); Fri, 10 Jun 2022 16:43:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349954AbiFJUna (ORCPT ); Fri, 10 Jun 2022 16:43:30 -0400 Received: from 13.mo561.mail-out.ovh.net (13.mo561.mail-out.ovh.net [188.165.33.202]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B30435AA2 for ; Fri, 10 Jun 2022 13:43:28 -0700 (PDT) Received: from player696.ha.ovh.net (unknown [10.108.20.107]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 7529A21DB3 for ; Fri, 10 Jun 2022 20:43:26 +0000 (UTC) Received: from sk2.org (82-65-25-201.subs.proxad.net [82.65.25.201]) (Authenticated sender: steve@sk2.org) by player696.ha.ovh.net (Postfix) with ESMTPSA id BB97B2147BC18; Fri, 10 Jun 2022 20:43:13 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-110S004e6fa79bf-d8bb-4492-9659-0d8f13915340, 3EA6D779A65D7DCBA15D92F127CD72011C01B2E3) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 Date: Fri, 10 Jun 2022 22:43:06 +0200 From: Stephen Kitt To: Sam Ravnborg Cc: Greg Kroah-Hartman , Noralf =?UTF-8?B?VHI=?= =?UTF-8?B?w7hubmVz?= , Thomas Zimmermann , Andy Shevchenko , Javier Martinez Canillas , Len Baker , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] staging: ftbft: Use backlight helper Message-ID: <20220610224306.325a6c91@heffalump.sk2.org> In-Reply-To: References: <20220607185516.1129900-1-steve@sk2.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/P4JAIYCU.yYfgTXqhIkbYUV"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Ovh-Tracer-Id: 12460897219021866630 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudduuddgudehtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhfogggtsehgtderreertdejnecuhfhrohhmpefuthgvphhhvghnucfmihhtthcuoehsthgvvhgvsehskhdvrdhorhhgqeenucggtffrrghtthgvrhhnpeeiheevvdeugeejffefteffvefhieegjeevhfekjeejvdelgfefkeehhfdufffhjeenucfkpheptddrtddrtddrtddpkedvrdeihedrvdehrddvtddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrheileeirdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepshhtvghvvgesshhkvddrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheeiud Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/P4JAIYCU.yYfgTXqhIkbYUV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Sam, On Fri, 10 Jun 2022 22:22:59 +0200, Sam Ravnborg wrote: > On Tue, Jun 07, 2022 at 08:55:16PM +0200, Stephen Kitt wrote: > > backlight_properties.fb_blank is deprecated. The states it represents > > are handled by other properties; but instead of accessing those > > properties directly, drivers should use the helpers provided by > > backlight.h. > >=20 > > Instead of manually checking the power state in struct > > backlight_properties, use backlight_is_blank(). > >=20 > > Signed-off-by: Stephen Kitt > > Cc: Greg Kroah-Hartman > > Cc: "Noralf Tr=C3=B8nnes" > > Cc: Thomas Zimmermann > > Cc: Andy Shevchenko > > Cc: Javier Martinez Canillas > > Cc: Len Baker > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-fbdev@vger.kernel.org > > Cc: linux-staging@lists.linux.dev > > --- > > drivers/staging/fbtft/fb_ssd1351.c | 3 +-- > > drivers/staging/fbtft/fbtft-core.c | 3 +-- > > 2 files changed, 2 insertions(+), 4 deletions(-) > >=20 > > diff --git a/drivers/staging/fbtft/fb_ssd1351.c > > b/drivers/staging/fbtft/fb_ssd1351.c index 6fd549a424d5..b8d55aa8c5c7 > > 100644 --- a/drivers/staging/fbtft/fb_ssd1351.c > > +++ b/drivers/staging/fbtft/fb_ssd1351.c > > @@ -196,8 +196,7 @@ static int update_onboard_backlight(struct > > backlight_device *bd) "%s: power=3D%d, fb_blank=3D%d\n", > > __func__, bd->props.power, bd->props.fb_blank); =20 > Could you try to kill this use of props.fb_blank too? ^^^^^^ > A local variable should do the trick. I have a pending patch changing this to show props.state instead, that way the debug info shows all the backlight-relevant information from props. How does that sound? Regards, Stephen --Sig_/P4JAIYCU.yYfgTXqhIkbYUV Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmKjrNoACgkQgNMC9Yht g5xQdg/+Orvis6KeWgiLd8jL6lqXH9XOKSzUodRrAYjprDDP0ZJq0NCh7JbJW+q3 OYkz1CNJ4/vsMOFU7lYPEPDRZqX+VHj2XBR11YZWTzUVi1f+ivSw/kDd5jzGe5xs opvDdvBTlUniPy3LAs84Z1unuX0P6JgTwvKX3oiBMgww1ym8b9B3Ha2nswe3yUI2 kjOUfz+Zv86RtoPF3R/LBPv4aP1UmVL3/Bgg1Qnb2llzb3L3JlUq6V5BtUuxj+CC vie/Wsfgsx9KXPa+GZUCaxm1q9uVUV21zHvZ3mCA5gew9jLg5wEFHmySony+2n+C wAd+0MY7tlL+YjfV9Ccgvvo39CHe0Wan10HpWWQNwfAQgdpTHmeI8cZ+Uho85sb2 QF3+Jz/mrnlSjHG4lqPLs0bXGb/rpVsDPbiivOWzamJGQyOx14VvrUrKyLUpLh4A BcB88hAvQ9z4pz8o3rkzfqi70KbDjbBpxQrpCXcwmBICUpfsm0ufteHA/7lSNEwq EXlDYFA66tyohK0IGuDUOf7wvDuuQjyqO8/Kc5+/xBDdlTPts3eDqmIaAF9ydTpZ 5+pgEJITNAcHm/ig5/Kjxkye4q6DAWKEX10FUBWmm6lpc90i3NuWHGDTpC7Ru3yl C5F9TZVMLyarmt00UEPhkARbBJrzOXqHGXQDWyiNxGCg1OB+GTc= =EB3v -----END PGP SIGNATURE----- --Sig_/P4JAIYCU.yYfgTXqhIkbYUV--