From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7BAC433EF for ; Tue, 14 Jun 2022 02:11:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352786AbiFNCLa (ORCPT ); Mon, 13 Jun 2022 22:11:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352606AbiFNCK0 (ORCPT ); Mon, 13 Jun 2022 22:10:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B42036E34; Mon, 13 Jun 2022 19:06:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DA075B816B0; Tue, 14 Jun 2022 02:06:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B136DC385A2; Tue, 14 Jun 2022 02:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172401; bh=eH+nCZz2UusixOYuS0U1QLfJWfEH2A8LccdZaK5mGc0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JkTS7K+9OVzyqvOKE+AGFeu6kZpE9/SFuEbeXseVDeNhcP4LVII2gXEteEdN0+Fdm /UjfWz0J7Eh//Ddc9U4wutwkaxD1dy/FzetbkVT0DFuA2Tg8yxbJRdZxnAdABR+6h4 G1i0wCHGOXt/M7I2k9GrPt6Qz/i0je56DnP8lNv7GohwbyDMRqI4g2pSxtIfEExc8L wheMrcS+6FSjcGDiqND2U6xHNV3Q4EVrqQ1Etkywpe+PoFThzhzZJhN2uZpnnDMWEC UZSZk7r3046Q/eRDq21F98+BHSOXKidyq2jBGuSgQAH8TYA7PI1LXdwwzg+UwGESq0 WUsTOTUBy2pHQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chengguang Xu , Dan Carpenter , "Martin K . Petersen" , Sasha Levin , jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.17 26/43] scsi: pmcraid: Fix missing resource cleanup in error case Date: Mon, 13 Jun 2022 22:05:45 -0400 Message-Id: <20220614020602.1098943-26-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614020602.1098943-1-sashal@kernel.org> References: <20220614020602.1098943-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chengguang Xu [ Upstream commit ec1e8adcbdf661c57c395bca342945f4f815add7 ] Fix missing resource cleanup (when '(--i) == 0') for error case in pmcraid_register_interrupt_handler(). Link: https://lore.kernel.org/r/20220529153456.4183738-6-cgxu519@mykernel.net Reviewed-by: Dan Carpenter Signed-off-by: Chengguang Xu Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pmcraid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index 928532180d32..71f829bd130e 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -4522,7 +4522,7 @@ pmcraid_register_interrupt_handler(struct pmcraid_instance *pinstance) return 0; out_unwind: - while (--i > 0) + while (--i >= 0) free_irq(pci_irq_vector(pdev, i), &pinstance->hrrq_vector[i]); pci_free_irq_vectors(pdev); return rc; -- 2.35.1