From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023CBC433EF for ; Tue, 14 Jun 2022 02:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354989AbiFNCTh (ORCPT ); Mon, 13 Jun 2022 22:19:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354684AbiFNCO6 (ORCPT ); Mon, 13 Jun 2022 22:14:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0A6C3CA4B; Mon, 13 Jun 2022 19:08:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F2F46101C; Tue, 14 Jun 2022 02:08:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF279C34114; Tue, 14 Jun 2022 02:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172516; bh=+1TLaFmHua8IBNRCN5x+vDP5VBwQ5CoiTgi7CN00kSY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EUW1xA0pGLTr/75ADSkwly1xGRiqU0J933Gk4hwecqj1mBRxG4Nsww3bLEQUbyoQh Oa5EyVG/vcvcAlhFAkmD/qLvHyMrus2yvfcbwfHvKFYPdR9L7dizRXm6uKd1f7I0X0 Lpwk9jG3tAnQvKw1IbfUYQzP+7N29Akg09cIQZ6VFslDFgveKVFR6A4v5WmqFkOvf3 otYlvHgcKBKJ+5+QXHQHcthDyGaaTf55VRMtyhUjduszq6m0s6z/be6QrtRCvXKjGa cZE0lMB77+VaQUK61WClr/AfK9h991aG0heFM03oAI1dfNzrgfnRTBdTXXeo0dWAc5 BMXQn//z8G0SA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mark Brown , Sasha Levin , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.10 13/29] ASoC: es8328: Fix event generation for deemphasis control Date: Mon, 13 Jun 2022 22:07:59 -0400 Message-Id: <20220614020815.1099999-13-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614020815.1099999-1-sashal@kernel.org> References: <20220614020815.1099999-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Brown [ Upstream commit 8259610c2ec01c5cbfb61882ae176aabacac9c19 ] Currently the put() method for the deemphasis control returns 0 when a new value is written to the control even if the value changed, meaning events are not generated. Fix this, skip the work of updating the value when it is unchanged and then return 1 after having done so. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220603123937.4013603-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/es8328.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c index 7e26231a596a..081b5f189632 100644 --- a/sound/soc/codecs/es8328.c +++ b/sound/soc/codecs/es8328.c @@ -161,13 +161,16 @@ static int es8328_put_deemph(struct snd_kcontrol *kcontrol, if (deemph > 1) return -EINVAL; + if (es8328->deemph == deemph) + return 0; + ret = es8328_set_deemph(component); if (ret < 0) return ret; es8328->deemph = deemph; - return 0; + return 1; } -- 2.35.1