From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2974ECCA483 for ; Tue, 14 Jun 2022 02:19:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354315AbiFNCTD (ORCPT ); Mon, 13 Jun 2022 22:19:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354471AbiFNCOr (ORCPT ); Mon, 13 Jun 2022 22:14:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5427A3BFBB; Mon, 13 Jun 2022 19:08:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BF8F3B80AC1; Tue, 14 Jun 2022 02:08:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7AF4C341C0; Tue, 14 Jun 2022 02:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172526; bh=YIs9ShMGN2GvWoBBYcpdcEv1M9la4CQJGFzqf7sJSWc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QHzLZ0b3bYW9k25hWbjC46AEzU6F3x983mQK7KHMzTG2tkh7hGkpoJGbwZic2lu/L 0EOVS4l3I/Gc5JB1SGmbgbQM5S1nwdRgvUbxGO0CkMFOFo3/7+ZiP9+GodfGMz5T/i bfI0S0n/9fDK/90ULYd0KS3oKZvRVts6tBeN1j0ZI0ipuABj1BrokPL3bfQMb1iGbR cw3vdRJ4Q9CAOItXd7EJL8KXm/kDhQ2HfvDrC9RTJ0YBatUDTRmRQ5uThcbZk5tW+6 DBHJwXbzEyotJ+c9XY+uQoSnrLY4+1YFIAtju08F++MNez/Lr34gp7mkYuAI+p6f/A 2CHoeN/HGuQ8g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chengguang Xu , Dan Carpenter , "Martin K . Petersen" , Sasha Levin , jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 20/29] scsi: pmcraid: Fix missing resource cleanup in error case Date: Mon, 13 Jun 2022 22:08:06 -0400 Message-Id: <20220614020815.1099999-20-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614020815.1099999-1-sashal@kernel.org> References: <20220614020815.1099999-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chengguang Xu [ Upstream commit ec1e8adcbdf661c57c395bca342945f4f815add7 ] Fix missing resource cleanup (when '(--i) == 0') for error case in pmcraid_register_interrupt_handler(). Link: https://lore.kernel.org/r/20220529153456.4183738-6-cgxu519@mykernel.net Reviewed-by: Dan Carpenter Signed-off-by: Chengguang Xu Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pmcraid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index cbe5fab793eb..ce10d680c56c 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -4528,7 +4528,7 @@ pmcraid_register_interrupt_handler(struct pmcraid_instance *pinstance) return 0; out_unwind: - while (--i > 0) + while (--i >= 0) free_irq(pci_irq_vector(pdev, i), &pinstance->hrrq_vector[i]); pci_free_irq_vectors(pdev); return rc; -- 2.35.1