From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DC59C43334 for ; Tue, 14 Jun 2022 02:26:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355163AbiFNC0c (ORCPT ); Mon, 13 Jun 2022 22:26:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354595AbiFNCX0 (ORCPT ); Mon, 13 Jun 2022 22:23:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 717F940921; Mon, 13 Jun 2022 19:10:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EF99AB8169E; Tue, 14 Jun 2022 02:10:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01113C341C0; Tue, 14 Jun 2022 02:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172635; bh=9ua7Tv8ngKzIg90avnelbsiLM5arPoUfgpVVXD8P87k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SgNm+QWjOjt1WrrO8MasWHbZ8nXrI6GlP6x211ZSPnHMSxTGSb8tRxsmXo6RUZ2qp uGq6t+YPD0EBfwJkdvlQt4z3NZZnRBkFlLurVvN3IuN7VZQ//q/rJQmN7wxO4iWq4k a7Jav1oyyogQcFlTsrjhbkqYgvzFUovX5ni8Y3Da0aOj4urz19fs8Kb92Z7RBNS5Lk jsupxFQM/C/HollDZcg2j2cLexPBMU+cv3QTsQi50S+a5TOe/nKA2AVL53YIIOLpRM 45nQeTAIXkCUC7pxAJluZSxr0INmng1Je19B+SSaoGae5OfgOL/ujPRevK8DVGHRVT pejbjHVgbY99A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: chengkaitao , "Michael S . Tsirkin" , Jason Wang , Sasha Levin , virtualization@lists.linux-foundation.org Subject: [PATCH AUTOSEL 4.14 11/14] virtio-mmio: fix missing put_device() when vm_cmdline_parent registration failed Date: Mon, 13 Jun 2022 22:10:16 -0400 Message-Id: <20220614021019.1100929-11-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614021019.1100929-1-sashal@kernel.org> References: <20220614021019.1100929-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: chengkaitao [ Upstream commit a58a7f97ba11391d2d0d408e0b24f38d86ae748e ] The reference must be released when device_register(&vm_cmdline_parent) failed. Add the corresponding 'put_device()' in the error handling path. Signed-off-by: chengkaitao Message-Id: <20220602005542.16489-1-chengkaitao@didiglobal.com> Signed-off-by: Michael S. Tsirkin Acked-by: Jason Wang Signed-off-by: Sasha Levin --- drivers/virtio/virtio_mmio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index 74dc7170fd35..181386e06cb7 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -635,6 +635,7 @@ static int vm_cmdline_set(const char *device, if (!vm_cmdline_parent_registered) { err = device_register(&vm_cmdline_parent); if (err) { + put_device(&vm_cmdline_parent); pr_err("Failed to register parent device!\n"); return err; } -- 2.35.1