From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4CCCCA480 for ; Tue, 14 Jun 2022 02:31:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355814AbiFNC3q (ORCPT ); Mon, 13 Jun 2022 22:29:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355537AbiFNCY0 (ORCPT ); Mon, 13 Jun 2022 22:24:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECB2936E0B; Mon, 13 Jun 2022 19:11:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 23616B816AC; Tue, 14 Jun 2022 02:10:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A13BC341C0; Tue, 14 Jun 2022 02:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172627; bh=5PFNQiwG1mXdKQ65RZEyeoluas5Avj05ZmhLZur5W38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XhECif1IaS4IX5sU/VLTSlSpm+O+ghH70CzpRLZCrcnFxsQrHsfk6TBslhbS4CX/C /4U4OgVHT304Zg0DaK8hK8rorhUJXHJbMZSypGkEQBKTfXXkgIs65rc9BR/N41V6sL gU2X5J6Cic3W7Km91ZsD/jU6INDy8CJQ6Ri5ojU1mSMmKjOM5Qb0oWlmuahycbeFpz /kgkXdCaVRUhhfoJanVHP4QtprYiqFLxnvwV17oRpkjtLJN62ynaCKX6s6AkUh8pko 8OHI/s0xYrJuzbZUBlGDhkyY88f6KFRZ7EFbXoVC94saq7wA4mUhefx876+it4bPhl jBGtzYA815Iqg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sergey Shtylyov , Damien Le Moal , Sasha Levin , tj@kernel.org, linux-ide@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 05/14] ata: libata-core: fix NULL pointer deref in ata_host_alloc_pinfo() Date: Mon, 13 Jun 2022 22:10:10 -0400 Message-Id: <20220614021019.1100929-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614021019.1100929-1-sashal@kernel.org> References: <20220614021019.1100929-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergey Shtylyov [ Upstream commit bf476fe22aa1851bab4728e0c49025a6a0bea307 ] In an unlikely (and probably wrong?) case that the 'ppi' parameter of ata_host_alloc_pinfo() points to an array starting with a NULL pointer, there's going to be a kernel oops as the 'pi' local variable won't get reassigned from the initial value of NULL. Initialize 'pi' instead to '&ata_dummy_port_info' to fix the possible kernel oops for good... Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool. Signed-off-by: Sergey Shtylyov Signed-off-by: Damien Le Moal Signed-off-by: Sasha Levin --- drivers/ata/libata-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index d3a7b3bb5043..08dc37a62f5a 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -6180,7 +6180,7 @@ struct ata_host *ata_host_alloc_pinfo(struct device *dev, const struct ata_port_info * const * ppi, int n_ports) { - const struct ata_port_info *pi; + const struct ata_port_info *pi = &ata_dummy_port_info; struct ata_host *host; int i, j; @@ -6188,7 +6188,7 @@ struct ata_host *ata_host_alloc_pinfo(struct device *dev, if (!host) return NULL; - for (i = 0, j = 0, pi = NULL; i < host->n_ports; i++) { + for (i = 0, j = 0; i < host->n_ports; i++) { struct ata_port *ap = host->ports[i]; if (ppi[j]) -- 2.35.1