From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED3EC433EF for ; Tue, 14 Jun 2022 07:48:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354851AbiFNHst (ORCPT ); Tue, 14 Jun 2022 03:48:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353011AbiFNHsp (ORCPT ); Tue, 14 Jun 2022 03:48:45 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 61E8A3EAA3 for ; Tue, 14 Jun 2022 00:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655192922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pA9hWNFeXf3Ws8HBvV+hgwjcVRJHqFaY7TkNSW+q34Y=; b=QoobN0GnxeZh/4xkqay/0DTuao72eWYj302PvKS2o4siM4rNHiw8jfkBLqk5xwAzhifz2M 2tLBZKdhjMqTzA3+KO5Q7SltIpThQFCWUDgEZR+71dQyBe3jpKPzPjBfK5DMxPaUTv6Bih MTcLw+AMNyt8LzppzNgP7IOwPQj9p90= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-644-HPctgxlAN8yJqRZY8HovEg-1; Tue, 14 Jun 2022 03:48:40 -0400 X-MC-Unique: HPctgxlAN8yJqRZY8HovEg-1 Received: by mail-ej1-f71.google.com with SMTP id k7-20020a1709062a4700b006fe92440164so2513506eje.23 for ; Tue, 14 Jun 2022 00:48:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pA9hWNFeXf3Ws8HBvV+hgwjcVRJHqFaY7TkNSW+q34Y=; b=Z367pjeIWm83CPVkns/yzRLygKqeHCl6SzP/OJjOcATr/KurQ2wEBdu0ghrKfPWfGJ KumeK10hhXUmWvNnC2354TBMEzQWYhVzp8rhh3Bj8WxHjR6i/ABPmNU212zDyG//jpe5 bxPdQ3O8j0nM3j4aTdIgoKKkncfV+rZD7x6HpHSLyGRp4nML842o8AKtRxyMA9fpq62E PMiFLdxlQh9ruBrTUxfSG5qLeSGJgo3W9TGKQoxceRS9y13cbdi3r0CJTH/6Itrf9eTU DY4wuj956Hbp/rXgRKCPdtQMN/SqJ5EIwFJjHduiOOq54GJjl/nrCWfhEJGDx4VV+jMY f0Ng== X-Gm-Message-State: AJIora9MXQuwiLGv67n3dbNTl7e6i20EiHTF39xYFGW5vpT/Iz824ppj wFR7TLAqLjivh6ZAZ4rWyrc1nuU72xiTOl3Pw/8kLcuoUqyKi6EP6ec/2Az2DcWwAjB3R4TQhO/ gn2ATHr+fGDkVilFUq1uXdgLa X-Received: by 2002:a05:6402:5384:b0:431:6d84:b451 with SMTP id ew4-20020a056402538400b004316d84b451mr4299284edb.46.1655192918268; Tue, 14 Jun 2022 00:48:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzP9bNFT/YiQLWZHW1O9vZ21ws6w7/jitcSKem//QoUBDC+1oG4tlyeyJ5BHfZ4fUU8Wr3ZaQ== X-Received: by 2002:a05:6402:5384:b0:431:6d84:b451 with SMTP id ew4-20020a056402538400b004316d84b451mr4299270edb.46.1655192918087; Tue, 14 Jun 2022 00:48:38 -0700 (PDT) Received: from gator (cst2-173-67.cust.vodafone.cz. [31.30.173.67]) by smtp.gmail.com with ESMTPSA id y18-20020aa7ce92000000b0042dc882c823sm6586576edv.70.2022.06.14.00.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 00:48:37 -0700 (PDT) Date: Tue, 14 Jun 2022 09:48:35 +0200 From: Andrew Jones To: shaoqin.huang@intel.com Cc: pbonzini@redhat.com, Shuah Khan , Sean Christopherson , David Matlack , Marc Zyngier , Oliver Upton , Ricardo Koller , Wei Wang , Peter Gonda , David Dunn , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: selftests: Remove the mismatched parameter comments Message-ID: <20220614074835.qto55feu74ionlh5@gator> References: <20220614224126.211054-1-shaoqin.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220614224126.211054-1-shaoqin.huang@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2022 at 04:41:19PM -0600, shaoqin.huang@intel.com wrote: > From: Shaoqin Huang > > There are some parameter being removed in function but the parameter > comments still exist, so remove them. > > Signed-off-by: Shaoqin Huang > --- > tools/testing/selftests/kvm/lib/kvm_util.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 1665a220abcb..58fdc82b20f4 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz, > * vm - Virtual Machine > * sz - Size in bytes > * vaddr_min - Minimum starting virtual address > - * data_memslot - Memory region slot for data pages > - * pgd_memslot - Memory region slot for new virtual translation tables > * > * Output Args: None > * > @@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm) > * vaddr - Virtuall address to map > * paddr - VM Physical Address > * npages - The number of pages to map > - * pgd_memslot - Memory region slot for new virtual translation tables > * > * Output Args: None > * > -- > 2.30.2 > Hi Shaoqin, Please check kvm/queue, the extra parameter comments have already been removed. Thanks, drew