From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 596C9C433EF for ; Tue, 14 Jun 2022 05:27:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238796AbiFNF1W (ORCPT ); Tue, 14 Jun 2022 01:27:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232427AbiFNF1T (ORCPT ); Tue, 14 Jun 2022 01:27:19 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C422275C0 for ; Mon, 13 Jun 2022 22:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655184438; x=1686720438; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UIKKOvGGbRq048qqE9SuNqIUY0R6M4fza8zcb3jNt94=; b=lc8qOuCGEkz+JkLZWrDzpWacwdTJqv0D+cYYeWleS1MRLNk9ZmmAMKP1 I9muzaDODY2z56PnkN58H1DGQ1boX+A02RFId+i/00lH7cbRLuYJXPywB qSpRFbPouBxjJDPu/34MrHq++c3yqlOqQzbSSpj5PmastElXKsDPXQMN5 tL/IrsboCdn2o+bxmi3H0Q2Fba1wm6Eozi1+MJIsvlPKN8pqudxjHFTVp sDkCfADAo31K3VnZBx8z3JDZ1LMJsVa/WkRY2Iq3i7t1Gqfazokqggk2y U1uEF14SUSs1BRIwPkAaKZlK1aydNpav69H1jwRVVfw4dqMPRhzHNcslh A==; X-IronPort-AV: E=McAfee;i="6400,9594,10377"; a="261542643" X-IronPort-AV: E=Sophos;i="5.91,299,1647327600"; d="scan'208";a="261542643" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 22:27:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,299,1647327600"; d="scan'208";a="612076247" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by orsmga008.jf.intel.com with ESMTP; 13 Jun 2022 22:27:15 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1o0z58-000LWF-H3; Tue, 14 Jun 2022 05:27:14 +0000 Date: Tue, 14 Jun 2022 13:27:01 +0800 From: kernel test robot To: jingyuwang , akpm@linux-foundation.org, rostedt@goodmis.org, mhiramat@kernel.org, vbabka@suse.cz, ahalaney@redhat.com, Jason@zx2c4.com, mark-pk.tsai@mediatek.com Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, jingyuwang Subject: Re: [PATCH] Fix the following checkpatch error: Message-ID: <202206141308.ushsZN6C-lkp@intel.com> References: <20220613202210.31759-1-jingyuwang_vip@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220613202210.31759-1-jingyuwang_vip@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi jingyuwang, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v5.19-rc2 next-20220610] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/jingyuwang/Fix-the-following-checkpatch-error/20220614-050258 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything config: s390-randconfig-r044-20220613 (https://download.01.org/0day-ci/archive/20220614/202206141308.ushsZN6C-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/35742a839670fa8937c7040160e16b7009b2a9ae git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review jingyuwang/Fix-the-following-checkpatch-error/20220614-050258 git checkout 35742a839670fa8937c7040160e16b7009b2a9ae # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): init/main.c:773:20: warning: no previous prototype for 'arch_post_acpi_subsys_init' [-Wmissing-prototypes] 773 | void __init __weak arch_post_acpi_subsys_init(void) { } | ^~~~~~~~~~~~~~~~~~~~~~~~~~ init/main.c:785:20: warning: no previous prototype for 'mem_encrypt_init' [-Wmissing-prototypes] 785 | void __init __weak mem_encrypt_init(void) { } | ^~~~~~~~~~~~~~~~ init/main.c:787:20: warning: no previous prototype for 'poking_init' [-Wmissing-prototypes] 787 | void __init __weak poking_init(void) { } | ^~~~~~~~~~~ In file included from include/linux/printk.h:6, from include/asm-generic/bug.h:22, from arch/s390/include/asm/bug.h:69, from include/linux/bug.h:5, from include/linux/thread_info.h:13, from arch/s390/include/asm/preempt.h:6, from include/linux/preempt.h:78, from arch/s390/include/asm/timex.h:13, from include/linux/timex.h:67, from include/linux/time32.h:13, from include/linux/time.h:60, from include/linux/stat.h:19, from include/linux/module.h:13, from init/main.c:17: >> include/linux/init.h:316:27: error: '__setup_str_set_debug_rodata' causes a section type conflict with 'initcall_level_names' 316 | static const char __setup_str_##unique_id[] __initconst \ | ^~~~~~~~~~~~ include/linux/init.h:329:9: note: in expansion of macro '__setup_param' 329 | __setup_param(str, fn, fn, 0) | ^~~~~~~~~~~~~ init/main.c:1461:1: note: in expansion of macro '__setup' 1461 | __setup("rodata=", set_debug_rodata); | ^~~~~~~ init/main.c:1344:20: note: 'initcall_level_names' was declared here 1344 | static const char *initcall_level_names[] __initconst = { | ^~~~~~~~~~~~~~~~~~~~ vim +316 include/linux/init.h ^1da177e4c3f415 Linus Torvalds 2005-04-16 308 ^1da177e4c3f415 Linus Torvalds 2005-04-16 309 /* ^1da177e4c3f415 Linus Torvalds 2005-04-16 310 * Only for really core code. See moduleparam.h for the normal way. ^1da177e4c3f415 Linus Torvalds 2005-04-16 311 * ^1da177e4c3f415 Linus Torvalds 2005-04-16 312 * Force the alignment so the compiler doesn't space elements of the ^1da177e4c3f415 Linus Torvalds 2005-04-16 313 * obs_kernel_param "array" too far apart in .init.setup. ^1da177e4c3f415 Linus Torvalds 2005-04-16 314 */ ^1da177e4c3f415 Linus Torvalds 2005-04-16 315 #define __setup_param(str, unique_id, fn, early) \ fd6c3a8dc44329d Jan Beulich 2009-03-12 @316 static const char __setup_str_##unique_id[] __initconst \ fd6c3a8dc44329d Jan Beulich 2009-03-12 317 __aligned(1) = str; \ ^1da177e4c3f415 Linus Torvalds 2005-04-16 318 static struct obs_kernel_param __setup_##unique_id \ 33def8498fdde18 Joe Perches 2020-10-21 319 __used __section(".init.setup") \ 147ad605dc12c51 Johan Hovold 2020-11-23 320 __aligned(__alignof__(struct obs_kernel_param)) \ ^1da177e4c3f415 Linus Torvalds 2005-04-16 321 = { __setup_str_##unique_id, fn, early } ^1da177e4c3f415 Linus Torvalds 2005-04-16 322 -- 0-DAY CI Kernel Test Service https://01.org/lkp