From: heliang <windhl@126.com>
To: linus.walleij@linaro.org, mturquette@baylibre.com, sboyd@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, windhl@126.com
Subject: [PATCH] drivers: clk: Add missing of_node_put() in clk-nomadik.c
Date: Wed, 15 Jun 2022 16:29:40 +0800 [thread overview]
Message-ID: <20220615082940.3960612-1-windhl@126.com> (raw)
In nomadik_src_init, of_find_matching_node() return a node pointer
with refcount incremented. We should use of_node_put() in fail path
or when it is not used anymore.
Signed-off-by: heliang <windhl@126.com>
---
drivers/clk/clk-nomadik.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
index bad2677e11ae..b3b8855d8890 100644
--- a/drivers/clk/clk-nomadik.c
+++ b/drivers/clk/clk-nomadik.c
@@ -97,6 +97,7 @@ static void __init nomadik_src_init(void)
}
src_base = of_iomap(np, 0);
if (!src_base) {
+ of_node_put(np);
pr_err("%s: must have src parent node with REGS (%pOFn)\n",
__func__, np);
return;
@@ -130,6 +131,7 @@ static void __init nomadik_src_init(void)
val &= ~SRC_XTALCR_MXTALEN;
pr_info("disabling MXTALO\n");
}
+ of_node_put(np);
writel(val, src_base + SRC_XTALCR);
register_reboot_notifier(&nomadik_clk_reboot_notifier);
}
--
2.25.1
next reply other threads:[~2022-06-15 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 8:29 heliang [this message]
2022-06-25 23:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615082940.3960612-1-windhl@126.com \
--to=windhl@126.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®