mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: korantwork@gmail.com
To: dave.hansen@linux.intel.com, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	trivial@kernel.org, Xinghui Li <korantli@tencent.com>
Subject: [PATCH] x86,iommu:cleanup misleading comment about SWIOTLB turned off by IOMMU
Date: Wed, 15 Jun 2022 17:06:39 +0800	[thread overview]
Message-ID: <20220615090639.34402-1-korantwork@gmail.com> (raw)

From: Xinghui Li <korantli@tencent.com>

According to commit 327d5b2fee91 ("iommu/vt-d: Allow 32bit devices to
uses DMA domain"), SWIOTLB could be enable even IOMMU exist.This comment
could mislead developer that there is an error enabling SWIOTLB when
they enable IOMMU.

Signed-off-by: Xinghui Li <korantli@tencent.com>
---
 arch/x86/kernel/pci-dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index 30bbe4abb5d6..c0434abf7e09 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -193,7 +193,6 @@ static int __init pci_iommu_init(void)
 	x86_init.iommu.iommu_init();
 
 #ifdef CONFIG_SWIOTLB
-	/* An IOMMU turned us off. */
 	if (x86_swiotlb_enable) {
 		pr_info("PCI-DMA: Using software bounce buffering for IO (SWIOTLB)\n");
 		swiotlb_print_info();
-- 
2.25.1


                 reply	other threads:[~2022-06-15  9:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220615090639.34402-1-korantwork@gmail.com \
    --to=korantwork@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=korantli@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®