From: Jan Kara <jack@suse.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Backlund <tmb@tmb.nu>, Jan Kara <jack@suse.cz>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
patches@kernelci.org, lkft-triage@lists.linaro.org,
Pavel Machek <pavel@denx.de>, Jon Hunter <jonathanh@nvidia.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Slade Watkins <slade@sladewatkins.com>
Subject: Re: [PATCH 5.15 000/251] 5.15.47-rc2 review
Date: Wed, 15 Jun 2022 12:04:32 +0200 [thread overview]
Message-ID: <20220615100432.gd7jeeyjk3qyayyi@quack3.lan> (raw)
In-Reply-To: <CAHk-=wix7+mGzS-hANyk7DZsZ1NgGMHjPzSQKggEomYrRCrP_Q@mail.gmail.com>
On Tue 14-06-22 11:51:35, Linus Torvalds wrote:
> On Tue, Jun 14, 2022 at 11:20 AM Thomas Backlund <tmb@tmb.nu> wrote:
> >
> > I "think" this is the suggested fix:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git/commit/?h=for_next&id=46b6418e26c7c26f98ff9c2c2310bce5ae2aa4dd
>
> Ugh, this is just too ugly for words.
>
> That's not a fix. That's a "hide the problem" patch.
I agree it is papering over the real problem. I consider that a stopgap
solution so that machines can boot until we find a cleaner solution.
> Now, admittedly clearly the "hide the problem" code already existed,
> and was just moved earlier, but I really think this whole "we're
> calling __mark_inode_dirty() on an inode that isn't even *initialized*
> yet" is a much deeper issue, and shouldn't have some hacky work-around
> in __mark_inode_dirty() that just happens to make it work.
>
> I don't mind that patch per se - moving the code is fine.
>
> But I *do* mind the patch when the reason is to hide that wrong
> ordering of operations.
>
> Now, maybe a proper fix might be to say that new_inode_pseudo() should
> always initialize i_state to I_DIRTY_ALL or something like that. The
> comment already says that they cannot participate in writeback, so
> maybe they should be disabled that way (ie a pseudo inode is always
> dirty and marking it dirty does nothing).
Sadly it is not so simple. Firstly, new_inode_pseudo() gets used for all
inodes (through new_inode()), secondly, tmpfs allocates fully standard
inodes through new_inode() as any other filesystem. We could check
writeback capabilities of the sb->s_bdi in new_inode_pseudo() but that
would not work for inodes that will become block device inodes because
blockdev_superblock has noop_backing_dev_info so we'd have to specialcase
that. Overall it looks a bit hairy to my taste.
> And then you get rid of the noop_backing_dev_info entirely.
And this would be even more difficult because there are other places that
expect there's *some* bdi associated with each sb.
> Or just make sure that noop_backing_dev_info is fully initialized
> before it's used.
>
> Because I think the real problem here is that things have a pointer to
> an uninitialized backing_dev_info.
I fully agree with this. IMHO we need to initialize noop_backing_dev_info
earlier but early init is not exactly my comfort zone so I have to verify
whether various stuff in cgwb_bdi_init() is safe to call so early...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2022-06-15 10:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 17:47 Thomas Backlund
2022-06-14 18:51 ` Linus Torvalds
2022-06-14 19:00 ` Linus Torvalds
2022-06-15 11:00 ` Jan Kara
2022-06-15 13:38 ` Jan Kara
2022-06-15 18:00 ` Guenter Roeck
2022-06-15 21:47 ` Jan Kara
2022-06-16 8:04 ` Suzuki K Poulose
2022-06-15 10:04 ` Jan Kara [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-13 18:19 Greg Kroah-Hartman
2022-06-13 21:00 ` Florian Fainelli
2022-06-14 3:06 ` Shuah Khan
2022-06-14 3:32 ` Fox Chen
2022-06-14 10:21 ` Sudip Mukherjee
2022-06-14 15:36 ` Guenter Roeck
2022-06-14 16:58 ` Allen Pais
2022-06-14 17:08 ` Guenter Roeck
2022-06-14 17:12 ` Greg Kroah-Hartman
2022-06-14 19:18 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615100432.gd7jeeyjk3qyayyi@quack3.lan \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=patches@kernelci.org \
--cc=pavel@denx.de \
--cc=shuah@kernel.org \
--cc=slade@sladewatkins.com \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=suzuki.poulose@arm.com \
--cc=tmb@tmb.nu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®