From: Guenter Roeck <linux@roeck-us.net>
To: Eugene Shalygin <eugene.shalygin@gmail.com>
Cc: Michael Carns <mike@carns.com>, Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: (asus-ec-sensors) add missing comma in board name list.
Date: Wed, 15 Jun 2022 08:19:24 -0700 [thread overview]
Message-ID: <20220615151924.GA3230585@roeck-us.net> (raw)
In-Reply-To: <20220615122544.140340-1-eugene.shalygin@gmail.com>
On Wed, Jun 15, 2022 at 02:25:44PM +0200, Eugene Shalygin wrote:
> From: Michael Carns <mike@carns.com>
>
> This fixes a regression where coma lead to concatenating board names
> and broke module loading for C8H.
>
> Fixes: 5b4285c57b6f ("hwmon: (asus-ec-sensors) fix Formula VIII definition")
>
> Signed-off-by: Michael Carns <mike@carns.com>
> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/asus-ec-sensors.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 886a71b4c64e..19d3ca71b360 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -268,7 +268,7 @@ static const struct ec_board_info board_info[] = {
> },
> {
> .board_names = {
> - "ROG CROSSHAIR VIII FORMULA"
> + "ROG CROSSHAIR VIII FORMULA",
> "ROG CROSSHAIR VIII HERO",
> "ROG CROSSHAIR VIII HERO (WI-FI)",
> },
prev parent reply other threads:[~2022-06-15 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 12:25 Eugene Shalygin
2022-06-15 15:19 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615151924.GA3230585@roeck-us.net \
--to=linux@roeck-us.net \
--cc=eugene.shalygin@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@carns.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®