From: Liang He <windhl@126.com>
To: tsbogend@alpha.franken.de, yangtiezhu@loongson.cn
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, windhl@126.com
Subject: [PATCH] mips: pic32: pic32mzda: Add missing of_node_put() in init.c
Date: Wed, 15 Jun 2022 23:28:49 +0800 [thread overview]
Message-ID: <20220615152849.3970438-1-windhl@126.com> (raw)
In pic32_of_prepare_platform_data(), of_find_compatible_node() will
return a node pointer with refcount incremented. We should use
of_node_put() when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
arch/mips/pic32/pic32mzda/init.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/mips/pic32/pic32mzda/init.c b/arch/mips/pic32/pic32mzda/init.c
index 129915616763..2b134d5d54e1 100644
--- a/arch/mips/pic32/pic32mzda/init.c
+++ b/arch/mips/pic32/pic32mzda/init.c
@@ -99,9 +99,13 @@ static int __init pic32_of_prepare_platform_data(struct of_dev_auxdata *lookup)
if (np) {
lookup->name = (char *)np->name;
if (lookup->phys_addr)
+ {
+ of_node_put(np);
continue;
+ }
if (!of_address_to_resource(np, 0, &res))
lookup->phys_addr = res.start;
+ of_node_put(np);
}
}
--
2.25.1
reply other threads:[~2022-06-15 15:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615152849.3970438-1-windhl@126.com \
--to=windhl@126.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®