From: Liang He <windhl@126.com>
To: john@phrozen.org, tsbogend@alpha.franken.de
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, windhl@126.com
Subject: [PATCH] mips: lantiq: Add missing of_node_put() in irq.c
Date: Wed, 15 Jun 2022 23:33:39 +0800 [thread overview]
Message-ID: <20220615153339.3970658-1-windhl@126.com> (raw)
In icu_of_init(), of_find_compatible_node() will return a node
pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
arch/mips/lantiq/irq.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
index b732495f138a..62f1b20a2169 100644
--- a/arch/mips/lantiq/irq.c
+++ b/arch/mips/lantiq/irq.c
@@ -396,6 +396,9 @@ int __init icu_of_init(struct device_node *node, struct device_node *parent)
ret = of_property_read_u32_array(eiu_node, "lantiq,eiu-irqs",
ltq_eiu_irq, exin_avail);
+
+ of_node_put(eiu_node);
+
if (ret)
panic("failed to load external irq resources");
@@ -409,6 +412,9 @@ int __init icu_of_init(struct device_node *node, struct device_node *parent)
panic("Failed to remap eiu memory");
}
+ /* if eiu_node&of_address_to_resource */
+ of_node_put(eiu_node);
+
return 0;
}
--
2.25.1
next reply other threads:[~2022-06-15 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 15:33 Liang He [this message]
2022-06-21 15:21 ` Thomas Bogendoerfer
2022-06-21 15:32 ` Liang He
2022-06-22 9:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615153339.3970658-1-windhl@126.com \
--to=windhl@126.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®