mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	luto@kernel.org, peterz@infradead.org, ak@linux.intel.com,
	dan.j.williams@intel.com, david@redhat.com, hpa@zytor.com,
	linux-kernel@vger.kernel.org,
	sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
	thomas.lendacky@amd.com, x86@kernel.org
Subject: Re: [PATCHv4 3/3] x86/tdx: Handle load_unaligned_zeropad() page-cross to a shared page
Date: Thu, 16 Jun 2022 01:43:03 +0300	[thread overview]
Message-ID: <20220615224303.el4qtowheu2rgpdn@black.fi.intel.com> (raw)
In-Reply-To: <1d190555-2bb1-e483-2405-e28ddabead07@intel.com>

On Wed, Jun 15, 2022 at 02:55:13PM -0700, Dave Hansen wrote:
> On 6/15/22 10:10, Kirill A. Shutemov wrote:
> >> I thought this whole exercise was kicked off by hitting this in testing.
> >>  Am I remembering this wrong?
> >>
> >>> https://lore.kernel.org/all/20220517153444.11195-10-kirill.shutemov@linux.intel.com/
> >> Says:
> >>
> >>> This is an actual, real-world problem which was discovered during TDX
> >>> testing.
> >> Or were you considering this a different problem somehow?
> > They are different.
> > 
> > The patch by the link addresses issue of load_unaligned_zeropad() stepping
> > onto unaccepted memory. This was triggered in practice.
> 
> OK, so we've got two problems both triggered by
> load_unaligned_zeropad(), but where the fixes are different.  We
> actually hit the "unaccepted memory one" in testing, but that made us
> think about other problems in the area and that's where this one came up.

I will reword it like this:

	The issue was discovered by analysis after triggering other issue with
	load_unaligned_zeropad().

Works for you?

-- 
 Kirill A. Shutemov

  reply	other threads:[~2022-06-15 22:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 12:01 [PATCHv4 0/3] An updated version of the load_unaligned_zeropad() fix Kirill A. Shutemov
2022-06-14 12:01 ` [PATCHv4 1/3] x86/tdx: Fix early #VE handling Kirill A. Shutemov
2022-06-17 21:53   ` [tip: x86/urgent] " tip-bot2 for Kirill A. Shutemov
2022-06-14 12:01 ` [PATCHv4 2/3] x86/tdx: Clarify RIP adjustments in #VE handler Kirill A. Shutemov
2022-06-17 21:53   ` [tip: x86/urgent] " tip-bot2 for Kirill A. Shutemov
2022-06-14 12:01 ` [PATCHv4 3/3] x86/tdx: Handle load_unaligned_zeropad() page-cross to a shared page Kirill A. Shutemov
2022-06-15 15:27   ` Dave Hansen
2022-06-15 17:10     ` Kirill A. Shutemov
2022-06-15 21:55       ` Dave Hansen
2022-06-15 22:43         ` Kirill A. Shutemov [this message]
2022-06-15 22:49           ` Dave Hansen
2022-06-15 23:16             ` Kirill A. Shutemov
2022-06-15 18:12   ` Dave Hansen
2022-06-15 22:32     ` Kirill A. Shutemov
2022-06-15 22:36       ` Dave Hansen
2022-06-15 23:16         ` Kirill A. Shutemov
2022-06-15 22:52   ` Kirill A. Shutemov
2022-06-15 23:34     ` Dave Hansen
2022-06-16  1:19       ` Kirill A. Shutemov
2022-06-16  6:35       ` David Laight
2022-06-17 21:53   ` [tip: x86/urgent] " tip-bot2 for Kirill A. Shutemov
2022-06-17 22:41   ` tip-bot2 for Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220615224303.el4qtowheu2rgpdn@black.fi.intel.com \
    --to=kirill.shutemov@linux.intel.com \
    --cc=ak@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=david@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®