From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 036B6C43334 for ; Wed, 15 Jun 2022 14:21:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349388AbiFOOU7 (ORCPT ); Wed, 15 Jun 2022 10:20:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347762AbiFOOUv (ORCPT ); Wed, 15 Jun 2022 10:20:51 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB29935A97; Wed, 15 Jun 2022 07:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655302822; x=1686838822; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BKDMg8fI4/oxE7Ct5GmeyilLeRcSIf/mmkwDwOrZrs4=; b=Np2qGOeiYtkc96s3V/SkabOv6grGMngz+uIUgNj0MIsQ7p9JJ/P4YvkD pZAWo1FGbSKGgaFrCuiGYLY8tn1Oq1mToKh1TKHABdRNTEaLNkwIh3PsC ULUYbqv6qSD6NVpaWExqm9uSfJAmonS8L1+046KU3Oixhbdir1Ppd8skj Rvnt5PG0nd/X6fCTupuOlrX7P2S2nGdbzVBjgp+w2C4Si1qzB83wudVWl +HJsyZTpHlvac8I435rlwjqc5wUWTXCWr5sYJ/mrF1ToiJczFB0NHw3md gqgu/OCnBTTsj+LDeZRmceW7WvsWu4qdCZRy7PG8yqeVRbexzNRuNCv2F w==; X-IronPort-AV: E=McAfee;i="6400,9594,10378"; a="280012571" X-IronPort-AV: E=Sophos;i="5.91,302,1647327600"; d="scan'208";a="280012571" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2022 07:20:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,302,1647327600"; d="scan'208";a="727417450" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 15 Jun 2022 07:20:18 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1o1TsX-000MvF-LV; Wed, 15 Jun 2022 14:20:17 +0000 Date: Wed, 15 Jun 2022 22:19:48 +0800 From: kernel test robot To: Pankaj Raghav , hch@lst.de, snitzer@redhat.com, damien.lemoal@opensource.wdc.com, axboe@kernel.dk Cc: kbuild-all@lists.01.org, bvanassche@acm.org, linux-kernel@vger.kernel.org, jiangbo.365@bytedance.com, hare@suse.de, pankydev8@gmail.com, dm-devel@redhat.com, jonathan.derrick@linux.dev, gost.dev@samsung.com, dsterba@suse.com, jaegeuk@kernel.org, linux-nvme@lists.infradead.org, Johannes.Thumshirn@wdc.com, linux-block@vger.kernel.org, Pankaj Raghav , Damien Le Moal Subject: Re: [PATCH v7 13/13] dm: add non power of 2 zoned target Message-ID: <202206152257.pnoPyl7X-lkp@intel.com> References: <20220615101920.329421-14-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220615101920.329421-14-p.raghav@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pankaj, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on device-mapper-dm/for-next linus/master v5.19-rc2 next-20220615] [cannot apply to song-md/md-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Pankaj-Raghav/block-make-blkdev_nr_zones-and-blk_queue_zone_no-generic-for-npo2-zsze/20220615-191927 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20220615/202206152257.pnoPyl7X-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/add4ab54d5b34d4a2f91f241007f23a56c164fb3 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Pankaj-Raghav/block-make-blkdev_nr_zones-and-blk_queue_zone_no-generic-for-npo2-zsze/20220615-191927 git checkout add4ab54d5b34d4a2f91f241007f23a56c164fb3 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/md/dm-zoned-npo2-target.c: In function 'dmz_npo2_ctr': >> drivers/md/dm-zoned-npo2-target.c:62:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 62 | int ret = 0; | ^~~ vim +/ret +62 drivers/md/dm-zoned-npo2-target.c 53 54 /* 55 * 56 * This target works on the complete zoned device. Partial mapping is not 57 * supported 58 */ 59 static int dmz_npo2_ctr(struct dm_target *ti, unsigned int argc, char **argv) 60 { 61 struct dmz_npo2_target *dmh = NULL; > 62 int ret = 0; 63 sector_t zsze; 64 sector_t disk_size; 65 66 if (argc < 1) 67 return -EINVAL; 68 69 dmh = kmalloc(sizeof(*dmh), GFP_KERNEL); 70 if (!dmh) 71 return -ENOMEM; 72 73 ret = dm_get_device(ti, argv[0], dm_table_get_mode(ti->table), 74 &dmh->dev); 75 76 zsze = blk_queue_zone_sectors(bdev_get_queue(dmh->dev->bdev)); 77 78 disk_size = get_capacity(dmh->dev->bdev->bd_disk); 79 80 if (ti->len != disk_size || ti->begin) { 81 DMERR("%pg Partial mapping of the target not supported", 82 dmh->dev->bdev); 83 return -EINVAL; 84 } 85 86 if (is_power_of_2(zsze)) { 87 DMERR("%pg zone size is power of 2", dmh->dev->bdev); 88 return -EINVAL; 89 } 90 91 dmh->zsze = zsze; 92 dmh->zsze_po2 = 1 << get_count_order_long(zsze); 93 dmh->zsze_diff = dmh->zsze_po2 - dmh->zsze; 94 95 ti->private = dmh; 96 ti->num_flush_bios = 1; 97 ti->num_discard_bios = 1; 98 ti->num_secure_erase_bios = 1; 99 ti->num_write_zeroes_bios = 1; 100 101 dmh->nr_zones = npo2_zone_no(dmh, ti->len); 102 ti->len = dmh->zsze_po2 * dmh->nr_zones; 103 104 return 0; 105 } 106 -- 0-DAY CI Kernel Test Service https://01.org/lkp