From: Alison Schofield <alison.schofield@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"Weiny, Ira" <ira.weiny@intel.com>,
"Verma, Vishal L" <vishal.l.verma@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] cxl/core: Add sysfs attribute get_poison for list retrieval
Date: Thu, 16 Jun 2022 13:39:49 -0700 [thread overview]
Message-ID: <20220616203949.GB1529208@alison-desk> (raw)
In-Reply-To: <20220616160412.00000c34@Huawei.com>
On Thu, Jun 16, 2022 at 08:04:12AM -0700, Jonathan Cameron wrote:
> On Tue, 14 Jun 2022 17:10:28 -0700
> alison.schofield@intel.com wrote:
>
> > From: Alison Schofield <alison.schofield@intel.com>
> >
> > The sysfs attribute, get_poison, allows user space to request the
> > retrieval of a CXL devices poison list for its persistent memory.
> >
> > From Documentation/ABI/.../sysfs-bus-cxl
> > (WO) When a '1' is written to this attribute the memdev
> > driver retrieves the poison list from the device. The list
> > includes addresses that are poisoned or would result in
> > poison if accessed, and the source of the poison. This
> > attribute is only visible for devices supporting the
> > capability. The retrieved errors are logged as kernel
> > trace events with the label: cxl_poison_list.
> >
> > Signed-off-by: Alison Schofield <alison.schofield@intel.com>
>
> Hi Alison,
>
> I'm planning to throw together QEMU support for this and test
> it. In meantime a few quick comments / suggestions inline.
Thanks Jonathan.
I've tested with a test patch that returns contrived output payloads,
and will look fwd to trying out w qemu,
>
> Thanks,
>
> Jonathan
>
> > ---
snip
> > +
> > + if (!sysfs_streq(buf, "1")) {
>
> Maybe kstrtobool? If you do then fine to leave the documentation claiming
> it's tighter as that'll tell people who actually read it to expect to
> write a 1.
>
Got it.
> > + dev_err(dev, "%s: unknown value: %s\n", attr->attr.name, buf);
>
> Feels noisy when I'd expect -EINVAL to be enough info to indicate an invalid
> parameter.
>
Got it.
> > + return -EINVAL;
> > + }
> > +
> > + rc = cxl_mem_get_poison_list(dev);
> > + if (rc) {
> > + dev_err(dev, "Failed to retrieve poison list %d\n", rc);
>
> Here I'd expect the error code to returned on the write to probably be enough
> info so not sure this error print is useful either.
>
Got it.
> > +
snip
> > + if (a == &dev_attr_get_poison.attr) {
> > + struct device *dev = container_of(kobj, struct device, kobj);
> > + struct cxl_memdev *cxlmd = to_cxl_memdev(dev);
> > + struct cxl_dev_state *cxlds = cxlmd->cxlds;
> > +
> > + if (!test_bit(CXL_MEM_COMMAND_ID_GET_POISON,
> > + cxlds->enabled_cmds))
> to_cxl_memdev(dev)->enabled_cmds))
> and drop the local variable is shorter and I don't htink it loses
> any readability.
>
Got it.
Thanks Jonathan!
next prev parent reply other threads:[~2022-06-16 20:40 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 0:10 [PATCH 0/3] CXL Poison List Retrieval & Tracing alison.schofield
2022-06-15 0:10 ` [PATCH 1/3] trace, cxl: Introduce a TRACE_EVENT for CXL Poison Records alison.schofield
2022-06-15 1:15 ` Steven Rostedt
2022-06-16 19:45 ` Davidlohr Bueso
2022-06-17 16:17 ` Jonathan Cameron
2022-06-17 18:04 ` Dan Williams
2022-06-15 0:10 ` [PATCH 2/3] cxl/mbox: Add GET_POISON_LIST mailbox command support alison.schofield
2022-06-15 3:22 ` Ira Weiny
2022-06-15 5:07 ` Alison Schofield
2022-06-15 15:01 ` Ira Weiny
2022-06-15 17:19 ` Alison Schofield
2022-06-16 19:43 ` Davidlohr Bueso
2022-06-16 20:34 ` Alison Schofield
2022-06-16 21:47 ` Davidlohr Bueso
2022-06-16 22:10 ` Alison Schofield
2022-06-16 22:20 ` Davidlohr Bueso
2022-06-16 22:45 ` Davidlohr Bueso
2022-06-16 23:15 ` Alison Schofield
2022-06-16 23:44 ` Verma, Vishal L
2022-06-17 0:03 ` Davidlohr Bueso
2022-06-17 19:02 ` Dan Williams
2022-06-20 10:53 ` Jonathan Cameron
2022-06-17 13:01 ` Jonathan Cameron
2022-06-17 14:05 ` Jonathan Cameron
2022-06-17 16:29 ` Alison Schofield
2022-06-17 17:29 ` Davidlohr Bueso
2022-06-17 19:32 ` Dan Williams
2022-06-20 10:56 ` Jonathan Cameron
2022-06-17 19:27 ` Dan Williams
2022-06-20 11:30 ` Jonathan Cameron
2022-06-17 18:26 ` Dan Williams
2022-06-15 0:10 ` [PATCH 3/3] cxl/core: Add sysfs attribute get_poison for list retrieval alison.schofield
2022-06-15 3:30 ` Ira Weiny
2022-06-16 15:04 ` Jonathan Cameron
2022-06-16 20:39 ` Alison Schofield [this message]
2022-06-17 18:42 ` Dan Williams
2022-06-18 0:21 ` Alison Schofield
2022-06-18 1:08 ` Dan Williams
2022-06-18 1:35 ` Alison Schofield
2022-06-17 17:52 ` [PATCH 0/3] CXL Poison List Retrieval & Tracing Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616203949.GB1529208@alison-desk \
--to=alison.schofield@intel.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®