From: Lin Feng <linf@wangsu.com>
To: gregkh@linuxfoundation.org, tj@kernel.org
Cc: linux-kernel@vger.kernel.org, linf@wangsu.com
Subject: [PATCH] kernfs/file.c: remove redundant error return counter assignment
Date: Fri, 17 Jun 2022 17:17:46 +0800 [thread overview]
Message-ID: <20220617091746.206515-1-linf@wangsu.com> (raw)
Since previous 'rc = -EINVAL;', rc value doesn't change, so not
necessary to re-assign it again.
Signed-off-by: Lin Feng <linf@wangsu.com>
---
fs/kernfs/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index e3abfa843879..54b2a13ac9a2 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -484,7 +484,6 @@ static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma)
* It is not possible to successfully wrap close.
* So error if someone is trying to use close.
*/
- rc = -EINVAL;
if (vma->vm_ops && vma->vm_ops->close)
goto out_put;
--
2.31.1
reply other threads:[~2022-06-17 9:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617091746.206515-1-linf@wangsu.com \
--to=linf@wangsu.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®