From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75F41C43334 for ; Fri, 17 Jun 2022 21:12:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382313AbiFQVL7 (ORCPT ); Fri, 17 Jun 2022 17:11:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234370AbiFQVL6 (ORCPT ); Fri, 17 Jun 2022 17:11:58 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB568C6B for ; Fri, 17 Jun 2022 14:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655500317; x=1687036317; h=date:from:to:cc:subject:message-id:mime-version; bh=vceCoTC97hzdFmBwYbG2vb0tVGeHg+jB5Ztu0uNnKfI=; b=UX3+Ken/HoZeR189BqFaqefKn7yG4NTWWo5zJOrfUmF/GAFyeEqnWLGU 8ajOmX+CS/MwcOOXNItxMizhAyj67YLZvIj7WmK9IMJY9PZLvr3YgZRoR ppFwkJaf4hXg7nWx6oHaDfxcRAI1vy5zhA4QAl91OevsZyiutY2GqOn3D t3bzHKUtCSSdyXWDvkSkBoKl1eF8980/3S1hFEqRh8N8k4GlrsZTQkzvU Q7e1U4ds2bpyQEuWIuwWG0NdO+fsYdEas57HzFr5rlZPX3vghwXtBR5IV BzpKi/fbJZC1bP293BmljwV3nYb4x2sDRaLf6BhOKlmIaBLOqFvuDlZ0W w==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="262628489" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="262628489" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 14:11:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="728497367" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 17 Jun 2022 14:11:56 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1o2JFz-000Pld-ES; Fri, 17 Jun 2022 21:11:55 +0000 Date: Sat, 18 Jun 2022 05:11:31 +0800 From: kernel test robot To: Daniel Borkmann Cc: kbuild-all@lists.01.org, Daniel Borkmann , linux-kernel@vger.kernel.org Subject: [cilium:pr/meta4 2/2] net/core/dev.c:3958:14: warning: no previous prototype for 'sch_cls_ingress' Message-ID: <202206180559.JlBsXKyh-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://github.com/cilium/linux.git pr/meta4 head: dcea837b60f0d9f8f3cdae284680659042f560d1 commit: dcea837b60f0d9f8f3cdae284680659042f560d1 [2/2] bpf: Add fd-based API to attach tc BPF programs config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20220618/202206180559.JlBsXKyh-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/cilium/linux/commit/dcea837b60f0d9f8f3cdae284680659042f560d1 git remote add cilium https://github.com/cilium/linux.git git fetch --no-tags cilium pr/meta4 git checkout dcea837b60f0d9f8f3cdae284680659042f560d1 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/core/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> net/core/dev.c:3958:14: warning: no previous prototype for 'sch_cls_ingress' [-Wmissing-prototypes] 3958 | unsigned int sch_cls_ingress(const void *pskb, const struct bpf_insn *null) | ^~~~~~~~~~~~~~~ >> net/core/dev.c:3998:14: warning: no previous prototype for 'sch_cls_egress' [-Wmissing-prototypes] 3998 | unsigned int sch_cls_egress(const void *pskb, const struct bpf_insn *null) | ^~~~~~~~~~~~~~ vim +/sch_cls_ingress +3958 net/core/dev.c 3955 3956 #ifdef CONFIG_NET_XGRESS 3957 #ifdef CONFIG_NET_CLS_ACT > 3958 unsigned int sch_cls_ingress(const void *pskb, const struct bpf_insn *null) 3959 { 3960 struct sk_buff *skb = (void *)pskb; 3961 struct mini_Qdisc *miniq; 3962 struct tcf_result res; 3963 int ret; 3964 3965 tc_skb_cb(skb)->mru = 0; 3966 tc_skb_cb(skb)->post_ct = false; 3967 3968 miniq = dev_sch_entry_pair(skb->dev->sch_ingress)->miniq; 3969 if (!miniq) 3970 return TC_ACT_UNSPEC; 3971 mini_qdisc_bstats_cpu_update(miniq, skb); 3972 __skb_pull(skb, skb->mac_len); 3973 ret = tcf_classify(skb, miniq->block, miniq->filter_list, &res, false); 3974 __skb_push(skb, skb->mac_len); 3975 /* Only tcf related quirks below. */ 3976 switch (ret) { 3977 case TC_ACT_SHOT: 3978 mini_qdisc_qstats_cpu_drop(miniq); 3979 break; 3980 case TC_ACT_OK: 3981 case TC_ACT_RECLASSIFY: 3982 skb->tc_index = TC_H_MIN(res.classid); 3983 ret = TC_ACT_OK; 3984 break; 3985 case TC_ACT_STOLEN: 3986 case TC_ACT_QUEUED: 3987 case TC_ACT_TRAP: 3988 ret = TC_ACT_CONSUMED; 3989 break; 3990 case TC_ACT_CONSUMED: 3991 /* Bump refcount given skb is now in use elsewhere. */ 3992 skb_get(skb); 3993 break; 3994 } 3995 return ret; 3996 } 3997 > 3998 unsigned int sch_cls_egress(const void *pskb, const struct bpf_insn *null) 3999 { 4000 struct sk_buff *skb = (void *)pskb; 4001 struct mini_Qdisc *miniq; 4002 struct tcf_result res; 4003 int ret; 4004 4005 tc_skb_cb(skb)->mru = 0; 4006 tc_skb_cb(skb)->post_ct = false; 4007 4008 miniq = dev_sch_entry_pair(skb->dev->sch_egress)->miniq; 4009 if (!miniq) 4010 return TC_ACT_UNSPEC; 4011 mini_qdisc_bstats_cpu_update(miniq, skb); 4012 ret = tcf_classify(skb, miniq->block, miniq->filter_list, &res, false); 4013 /* Only tcf related quirks below. */ 4014 switch (ret) { 4015 case TC_ACT_SHOT: 4016 mini_qdisc_qstats_cpu_drop(miniq); 4017 break; 4018 case TC_ACT_OK: 4019 case TC_ACT_RECLASSIFY: 4020 skb->tc_index = TC_H_MIN(res.classid); 4021 ret = TC_ACT_OK; 4022 break; 4023 case TC_ACT_STOLEN: 4024 case TC_ACT_QUEUED: 4025 case TC_ACT_TRAP: 4026 ret = TC_ACT_CONSUMED; 4027 break; 4028 case TC_ACT_CONSUMED: 4029 /* Bump refcount given skb is now in use elsewhere. */ 4030 skb_get(skb); 4031 break; 4032 } 4033 return ret; 4034 } 4035 #endif /* CONFIG_NET_CLS_ACT */ 4036 -- 0-DAY CI Kernel Test Service https://01.org/lkp