From: Liang He <windhl@126.com>
To: davem@davemloft.net, windhl@126.com, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] sparc: kernel: Fix refcount bug in irq_64.c
Date: Sun, 19 Jun 2022 14:18:23 +0800 [thread overview]
Message-ID: <20220619061823.4066040-1-windhl@126.com> (raw)
In map_prom_timers(), of_find_node_by_path() will return
a node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
arch/sparc/kernel/irq_64.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/sparc/kernel/irq_64.c b/arch/sparc/kernel/irq_64.c
index c8848bb681a1..84abfe584a08 100644
--- a/arch/sparc/kernel/irq_64.c
+++ b/arch/sparc/kernel/irq_64.c
@@ -909,12 +909,13 @@ static u64 prom_limit0, prom_limit1;
static void map_prom_timers(void)
{
- struct device_node *dp;
+ struct device_node *dp, *tp;
const unsigned int *addr;
/* PROM timer node hangs out in the top level of device siblings... */
- dp = of_find_node_by_path("/");
- dp = dp->child;
+ tp = of_find_node_by_path("/");
+ dp = tp->child;
+ of_node_put(tp);
while (dp) {
if (of_node_name_eq(dp, "counter-timer"))
break;
--
2.25.1
reply other threads:[~2022-06-19 6:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220619061823.4066040-1-windhl@126.com \
--to=windhl@126.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®