From: Liang He <windhl@126.com>
To: dmitry.torokhov@gmail.com
Cc: windhl@126.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] input/serio: Fix refcount leak bug in i8042-sparcio
Date: Sun, 19 Jun 2022 15:30:36 +0800 [thread overview]
Message-ID: <20220619073036.4067872-1-windhl@126.com> (raw)
In i8042_platform_init() and i8042_platform_exit(), we need call
of_node_put() to keep refcount balance.
Signed-off-by: Liang He <windhl@126.com>
---
drivers/input/serio/i8042-sparcio.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/input/serio/i8042-sparcio.h b/drivers/input/serio/i8042-sparcio.h
index fce76812843b..a2a9db9220d7 100644
--- a/drivers/input/serio/i8042-sparcio.h
+++ b/drivers/input/serio/i8042-sparcio.h
@@ -108,6 +108,8 @@ static int __init i8042_platform_init(void)
struct device_node *root = of_find_node_by_path("/");
const char *name = of_get_property(root, "name", NULL);
+ of_node_put(root);
+
if (name && !strcmp(name, "SUNW,JavaStation-1")) {
/* Hardcoded values for MrCoffee. */
i8042_kbd_irq = i8042_aux_irq = 13 | 0x20;
@@ -139,6 +141,8 @@ static inline void i8042_platform_exit(void)
struct device_node *root = of_find_node_by_path("/");
const char *name = of_get_property(root, "name", NULL);
+ of_node_put(root);
+
if (!name || strcmp(name, "SUNW,JavaStation-1"))
platform_driver_unregister(&sparc_i8042_driver);
}
--
2.25.1
next reply other threads:[~2022-06-19 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-19 7:30 Liang He [this message]
2022-07-09 4:49 ` Dmitry Torokhov
2022-07-10 1:37 ` Liang He
2022-07-11 3:19 ` Dmitry Torokhov
2022-07-11 4:57 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220619073036.4067872-1-windhl@126.com \
--to=windhl@126.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®