From: "José Expósito" <jose.exposito89@gmail.com>
To: javierm@redhat.com
Cc: davidgow@google.com, dlatypov@google.com, tzimmermann@suse.de,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com,
maira.canal@usp.br, isabbasso@riseup.net,
magalilemes00@gmail.com, tales.aparecida@gmail.com,
dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org,
"José Expósito" <jose.exposito89@gmail.com>
Subject: [PATCH v4 0/3] KUnit tests for drm_format_helper
Date: Mon, 20 Jun 2022 18:06:37 +0200 [thread overview]
Message-ID: <20220620160640.3790-1-jose.exposito89@gmail.com> (raw)
Hello everyone,
Following the style used in the selftest to KUnit series [1] and the AMD
series [2], the tests were moved to the "tests" folder.
In addition, to be consistent naming functions, I renamed the
kunit_suite and the test cases to use underscores as suggested in [3].
It is not clear yet whether we want to have one or multiple Kconfig
symbols and select which test should be built. However, refactoring from
one approach to the other is quite simple, so I think we should be fine
choosing the simpler option now and refactoring if required.
Thanks a lot,
José Expósito
[1] https://lore.kernel.org/dri-devel/20220615135824.15522-1-maira.canal@usp.br/T/
[2] https://lore.kernel.org/dri-devel/20220608010709.272962-1-maira.canal@usp.br/
[3] https://www.kernel.org/doc/html/latest/dev-tools/kunit/style.html
RFC -> v1: https://lore.kernel.org/dri-devel/20220530102017.471865-1-jose.exposito89@gmail.com/T/
- Add .kunitconfig (Maxime Ripard)
- Fix memory leak (Daniel Latypov)
- Make config option generic (Javier Martinez Canillas):
DRM_FORMAR_HELPER_TEST -> DRM_KUNIT_TEST
- Remove DISABLE_STRUCTLEAK_PLUGIN (Daniel Latypov)
v1 -> v2: https://lore.kernel.org/dri-devel/20220606095516.938934-1-jose.exposito89@gmail.com/T/
Thomas Zimmermann:
- Add DRM_RECT_INIT() macro
- Move tests to drivers/gpu/drm/kunit
- Improve test documentation
v2 -> v3: https://lore.kernel.org/dri-devel/20220612161248.271590-1-jose.exposito89@gmail.com/T/
- Use designated initializer in DRM_RECT_INIT (Jani Nikula)
- Simplify the "conversion_buf_size" helper
v3 -> v4: https://lore.kernel.org/dri-devel/20220616183852.GA12343@elementary/T/
- Move the source to the "tests" folder
- Use "_" in kunit_suite and cases:
https://www.kernel.org/doc/html/latest/dev-tools/kunit/style.html
- Reviewed-by and Acked-by tags
José Expósito (3):
drm/rect: Add DRM_RECT_INIT() macro
drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()
drm/doc: Add KUnit documentation
Documentation/gpu/drm-internals.rst | 32 ++++
drivers/gpu/drm/Kconfig | 16 ++
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/tests/.kunitconfig | 3 +
drivers/gpu/drm/tests/Makefile | 3 +
.../gpu/drm/tests/drm_format_helper_test.c | 161 ++++++++++++++++++
include/drm/drm_rect.h | 16 ++
7 files changed, 232 insertions(+)
create mode 100644 drivers/gpu/drm/tests/.kunitconfig
create mode 100644 drivers/gpu/drm/tests/Makefile
create mode 100644 drivers/gpu/drm/tests/drm_format_helper_test.c
--
2.25.1
next reply other threads:[~2022-06-20 16:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 16:06 José Expósito [this message]
2022-06-20 16:06 ` [PATCH v4 1/3] drm/rect: Add DRM_RECT_INIT() macro José Expósito
2022-06-21 9:38 ` David Gow
2022-06-21 10:02 ` Thomas Zimmermann
2022-06-21 10:13 ` Jani Nikula
2022-06-22 7:12 ` David Gow
2022-06-20 16:06 ` [PATCH v4 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332() José Expósito
2022-06-21 9:38 ` David Gow
2022-06-21 17:37 ` José Expósito
2022-06-20 16:06 ` [PATCH v4 3/3] drm/doc: Add KUnit documentation José Expósito
2022-06-21 9:38 ` David Gow
2022-06-21 18:15 ` José Expósito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620160640.3790-1-jose.exposito89@gmail.com \
--to=jose.exposito89@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=isabbasso@riseup.net \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=magalilemes00@gmail.com \
--cc=maira.canal@usp.br \
--cc=mripard@kernel.org \
--cc=tales.aparecida@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®