From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
rostedt@goodmis.org, Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <frederic@kernel.org>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH rcu 23/23] context_tracking: Interrupts always disabled for ct_idle_exit()
Date: Mon, 20 Jun 2022 16:10:29 -0700 [thread overview]
Message-ID: <20220620231029.3844583-23-paulmck@kernel.org> (raw)
In-Reply-To: <20220620231027.GA3844372@paulmck-ThinkPad-P17-Gen-1>
From: Peter Zijlstra <peterz@infradead.org>
Now that the idle-loop cleanups have ensured that rcu_idle_exit() is
always invoked with interrupts disabled, remove the interrupt disabling
in favor of a debug check.
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/context_tracking.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
index 1da44803fd319..99310cf5b0254 100644
--- a/kernel/context_tracking.c
+++ b/kernel/context_tracking.c
@@ -332,11 +332,8 @@ EXPORT_SYMBOL_GPL(ct_idle_enter);
*/
void noinstr ct_idle_exit(void)
{
- unsigned long flags;
-
- raw_local_irq_save(flags);
+ WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) && !raw_irqs_disabled());
ct_kernel_enter(false, RCU_DYNTICKS_IDX - CONTEXT_IDLE);
- raw_local_irq_restore(flags);
}
EXPORT_SYMBOL_GPL(ct_idle_exit);
--
2.31.1.189.g2e36527f23
prev parent reply other threads:[~2022-06-20 23:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 23:10 [PATCH rcu 0/23] RCU/context-tracking updates for v5.20 Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 01/23] rcu: Dump rcuc kthread status for CPUs not reporting quiescent state Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 02/23] rcu: Apply noinstr to rcu_idle_enter() and rcu_idle_exit() Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 03/23] context_tracking: Remove unused context_tracking_in_user() Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 04/23] context_tracking: Add a note about noinstr VS unsafe context tracking functions Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 05/23] context_tracking: Rename __context_tracking_enter/exit() to __ct_user_enter/exit() Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 06/23] context_tracking: Rename context_tracking_user_enter/exit() to user_enter/exit_callable() Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 07/23] context_tracking: Rename context_tracking_enter/exit() to ct_user_enter/exit() Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 08/23] context_tracking: Rename context_tracking_cpu_set() to ct_cpu_track_user() Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 09/23] context_tracking: Split user tracking Kconfig Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 10/23] context_tracking: Take idle eqs entrypoints over RCU Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 11/23] context_tracking: Take IRQ " Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 12/23] context_tracking: Take NMI " Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 13/23] rcu/context-tracking: Remove rcu_irq_enter/exit() Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 14/23] rcu/context_tracking: Move dynticks counter to context tracking Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 15/23] rcu/context_tracking: Move dynticks_nesting " Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 16/23] rcu/context_tracking: Move dynticks_nmi_nesting " Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 17/23] rcu/context-tracking: Move deferred nocb resched " Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 18/23] rcu/context-tracking: Move RCU-dynticks internal functions to context_tracking Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 19/23] rcu/context-tracking: Remove unused and/or unecessary middle functions Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 20/23] context_tracking: Convert state to atomic_t Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 21/23] rcu/context_tracking: Merge dynticks counter and context tracking states Paul E. McKenney
2022-06-20 23:10 ` [PATCH rcu 22/23] MAINTAINERS: Add Paul as context tracking maintainer Paul E. McKenney
2022-06-20 23:10 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620231029.3844583-23-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=frederic@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®