From: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
To: <miquel.raynal@bootlin.com>, <vigneshr@ti.com>
Cc: <git@amd.com>, <boris.brezillon@collabora.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<amit.kumar-mahapatra@amd.com>, <akumarma@amd.com>,
Olga Kitaina <okitain@gmail.com>,
Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Subject: [PATCH v2 2/2] mtd: rawnand: arasan: Fix clock rate in NV-DDR
Date: Tue, 21 Jun 2022 14:25:00 +0530 [thread overview]
Message-ID: <20220621085500.1005-3-amit.kumar-mahapatra@xilinx.com> (raw)
In-Reply-To: <20220621085500.1005-1-amit.kumar-mahapatra@xilinx.com>
From: Olga Kitaina <okitain@gmail.com>
According to the Arasan NAND controller spec, the flash clock rate for SDR
must be <= 100 MHz, while for NV-DDR it must be the same as the rate of the
CLK line for the mode. The driver previously always set 100 MHz for NV-DDR,
which would result in incorrect behavior for NV-DDR modes 0-4.
The appropriate clock rate can be calculated from the NV-DDR timing
parameters as 1/tCK, or for rates measured in picoseconds,
10^12 / nand_nvddr_timings->tCK_min.
Signed-off-by: Olga Kitaina <okitain@gmail.com>
Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
---
drivers/mtd/nand/raw/arasan-nand-controller.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/raw/arasan-nand-controller.c b/drivers/mtd/nand/raw/arasan-nand-controller.c
index 4f6da82dd2b1..0eff069d7f80 100644
--- a/drivers/mtd/nand/raw/arasan-nand-controller.c
+++ b/drivers/mtd/nand/raw/arasan-nand-controller.c
@@ -1044,10 +1044,20 @@ static int anfc_setup_interface(struct nand_chip *chip, int target,
DQS_BUFF_SEL_OUT(dqs_mode);
}
- ret = clk_set_rate(nfc->bus_clk, ANFC_XLNX_SDR_DFLT_CORE_CLK);
- if (ret) {
- dev_err(nfc->dev, "Failed to change bus clock rate\n");
- return ret;
+ if (nand_interface_is_sdr(conf)) {
+ ret = clk_set_rate(nfc->bus_clk, ANFC_XLNX_SDR_DFLT_CORE_CLK);
+ if (ret) {
+ dev_err(nfc->dev, "Failed to change bus clock rate\n");
+ return ret;
+ }
+ } else {
+ /* ONFI timings are defined in picoseconds */
+ ret = clk_set_rate(nfc->bus_clk, div_u64((u64)NSEC_PER_SEC * 1000,
+ conf->timings.nvddr.tCK_min));
+ if (ret) {
+ dev_err(nfc->dev, "Failed to change bus clock rate\n");
+ return ret;
+ }
}
/*
--
2.17.1
prev parent reply other threads:[~2022-06-21 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 8:54 [PATCH v2 0/2] " Amit Kumar Mahapatra
2022-06-21 8:54 ` [PATCH v2 1/2] mtd: rawnand: arasan: Update NAND bus clock instead of system clock Amit Kumar Mahapatra
2022-06-24 18:45 ` Miquel Raynal
2022-06-27 16:23 ` Mahapatra, Amit Kumar
2022-06-21 8:55 ` Amit Kumar Mahapatra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621085500.1005-3-amit.kumar-mahapatra@xilinx.com \
--to=amit.kumar-mahapatra@xilinx.com \
--cc=akumarma@amd.com \
--cc=amit.kumar-mahapatra@amd.com \
--cc=boris.brezillon@collabora.com \
--cc=git@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=okitain@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®